74785[TASK] Remove type annotations where possible
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 210
- Build/phpstan/phpstan-baseline.neon+3 −63
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php+0 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+0 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+0 −1
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+0 −1
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php2+0 −5
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+0 −1
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+2 −1
- typo3/sysext/backend/Classes/Controller/ContextMenuController.php+0 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+0 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+0 −16
- typo3/sysext/backend/Classes/Controller/LogoutController.php+2 −1
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+0 −1
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+0 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+0 −1
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+0 −2
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+0 −1
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+0 −1
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+0 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+0 −1
Show 190 more files
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+0 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseLanguageRows.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseSystemLanguageRows.php+0 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+0 −8
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+0 −2
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+0 −1
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+0 −2
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+0 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+0 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+0 −1
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/Element/AbstractFormElementTest.php3+0 −3
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php7+0 −5
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php2+0 −1
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+1 −1
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+0 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+0 −1
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+0 −2
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+0 −1
- typo3/sysext/core/Classes/Configuration/Richtext.php+0 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+2 −3
- typo3/sysext/core/Classes/Core/ClassLoadingInformation.php+0 −2
- typo3/sysext/core/Classes/Database/RelationHandler.php+0 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php+0 −1
- typo3/sysext/core/Classes/DataHandling/Model/RecordStateFactory.php+0 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php7+2 −9
- typo3/sysext/core/Classes/DataHandling/ItemProcessingService.php+0 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+0 −1
- typo3/sysext/core/Classes/Hooks/BackendUserGroupIntegrityCheck.php+0 −2
- typo3/sysext/core/Classes/Log/Logger.php+0 −1
- typo3/sysext/core/Classes/Log/LogManager.php+4 −3
- typo3/sysext/core/Classes/Page/DefaultJavaScriptAssetTrait.php+0 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+0 −2
- typo3/sysext/core/Classes/Resource/Collection/FolderBasedFileCollection.php+2 −2
- typo3/sysext/core/Classes/Resource/Collection/StaticFileCollection.php+0 −1
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+0 −2
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+0 −1
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+0 −3
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+1 −4
- typo3/sysext/core/Classes/Resource/Utility/ListUtility.php7+2 −2
- typo3/sysext/core/Classes/Resource/FileRepository.php+0 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+2 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+0 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+0 −6
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+0 −2
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+0 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+0 −4
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −5
- typo3/sysext/core/Classes/Utility/MailUtility.php+0 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+0 −1
- typo3/sysext/core/Documentation/Changelog/9.2/Feature-83736-ExtendedPSR-7RequestsWithTYPO3ServerParameters.rst+0 −1
- typo3/sysext/core/Documentation/Changelog/11.3/Deprecation-94223-ExtbaseRequest-getBaseUri.rst+0 −1
- typo3/sysext/core/Documentation/Changelog/11.3/Deprecation-94228-DeprecateExtbaseRequestGetRequestUri.rst+0 −1
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+0 −4
- typo3/sysext/core/Tests/Functional/Imaging/ImageMagickFileTest.php2+0 −2
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+0 −13
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcuBackendTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+4 −7
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+0 −6
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+0 −6
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+0 −4
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+0 −3
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+0 −2
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Log/Writer/DatabaseWriterTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+0 −12
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+1 −21
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+1 −20
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+0 −5
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+0 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+1 −5
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Service/DependencyOrderingServiceTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php2+1 −12
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+0 −1
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+0 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+0 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryFactory.php+0 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php2+4 −4
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationBuilder.php2+2 −3
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractGenericObjectValidator.php2+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+0 −8
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+0 −6
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+0 −10
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+0 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php2+4 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+0 −5
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+0 −1
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+0 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+1 −4
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+0 −1
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+0 −1
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+0 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+0 −2
- typo3/sysext/form/Tests/Unit/Domain/Finishers/ClosureFinisherTest.php+3 −3
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+0 −8
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+0 −10
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+0 −4
- typo3/sysext/frontend/Classes/Category/Collection/CategoryCollection.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+0 −2
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+0 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+0 −2
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+0 −1
- typo3/sysext/frontend/Tests/Functional/Request/InternalRequestDataMappingTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+0 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+0 −1
- typo3/sysext/impexp/Tests/Functional/Export/ExportPageTreeViewTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php+0 −3
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+0 −4
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+0 −6
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+0 −5
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+0 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+0 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+0 −3
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php2+2 −2
- typo3/sysext/install/Classes/Controller/UpgradeController.php+2 −1
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+0 −2
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+0 −1
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+0 −2
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+0 −22
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+0 −28
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+0 −41
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+0 −23
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+0 −13
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+0 −4
- typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php+0 −6
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+0 −4
- typo3/sysext/install/Tests/Unit/Service/EnableFileServiceTest.php+0 −4
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+0 −15
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+0 −1
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+0 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+0 −1
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+0 −1
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+0 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −3
- typo3/sysext/reports/Classes/Report/Status/FalStatus.php+0 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+0 −2
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php+0 −2
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+0 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+2 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+2 −1
- typo3/sysext/scheduler/Classes/Execution.php+0 −1
- typo3/sysext/scheduler/Classes/Scheduler.php+0 −1
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+0 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+0 −1
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+2 −1
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+0 −1
Review log 5673
Show 3648 earlier messages
-
Simon Schaufelberger uploaded patch set 1 05/29/22, 00:36
-
Simon Schaufelberger uploaded patch set 2 05/29/22, 00:42
-
core-ci voted on patch set 1 V -1 05/29/22, 00:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27536
-
core-ci voted on patch set 2 V -1 05/29/22, 00:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27537
-
Simon Schaufelberger uploaded patch set 3 05/29/22, 00:51
-
core-ci voted on patch set 3 V -1 05/29/22, 00:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27538
-
Oliver Klee commented on patch set 3 05/29/22, 09:56
As far as I can see, it does not add a new error. Am I missing something? -
Oliver Klee uploaded patch set 4 05/29/22, 10:50
-
core-ci voted on patch set 4 V +1 05/29/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27542
-
Oliver Klee commented on patch set 4 05/29/22, 11:15
If I had a time machine, I'd advise your younger self to split this up, e.g., by extension, or by having different changes for makeInstance vs. the mocks. :-) (In other word, I find this change a bit big, which makes the review somewhat tedious.)Reply
DoneListUtility.php:39Instead, we should annotate the parameter $folders with this: Folder[]ExtensionManagementUtilityTest.php:1515Here, we also need the "real" class for the intersection type.PropertyMappingConfigurationBuilder.php:35Instead of this type annotation, we should change the type of $type in the @param annotation to this: class-string<PropertyMappingConfiguration>AbstractFileFolderConverter.php:67The indentation is off here.AbstractGenericObjectValidator.php:87|nullPersistenceManagerTest.php:341We cam remove this line if we annotation $repositoryClassNameWithNamespace with this type: class-string<RepositoryInterface>IndexSearchRepository.php:1130This needs a |null. -
Oliver Klee commented on patch set 4 05/29/22, 11:29
ListUtility.php:39ReplyDoneExtensionManagementUtilityTest.php:1515ReplyDonePropertyMappingConfigurationBuilder.php:35ReplyDoneAbstractFileFolderConverter.php:67ReplyDoneAbstractGenericObjectValidator.php:87ReplyDonePersistenceManagerTest.php:341ReplyDoneIndexSearchRepository.php:1130ReplyDone -
Oliver Klee uploaded patch set 5 05/29/22, 11:29
-
Oliver Klee voted on patch set 5 V +1 CR +1 05/29/22, 11:29
-
core-ci voted on patch set 5 V -1 05/29/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27543
-
Oliver Klee commented on patch set 5 05/29/22, 11:41
Just had a chat with Stefan: This should be main-only as this is cleanup only, but it will be somewhat of a pain to backport. -
Oliver Klee uploaded patch set 6 05/29/22, 11:41
-
Oliver Klee commented on patch set 5 V +1 CR +1 05/29/22, 11:41
Reply
Done -
Oliver Klee voted on patch set 6 V +1 CR +1 05/29/22, 11:42
-
core-ci voted on patch set 6 V +1 05/29/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27544
-
Simon Schaufelberger commented on patch set 6 05/29/22, 11:54
Reply
shouldn't the code almost be identical with 11.5? That is why I think that it should be relatively easy to backport. If not, I would have done it for you ;) -
Simon Schaufelberger commented on patch set 6 05/29/22, 11:54
thanks for taking over Oliver! I really appreciate! -
Oliver Klee commented on patch set 6 05/29/22, 11:56
Reply
If you're willing to do the backport, then please let's have it. (The issue was only that it might be tedious work, not that it would be risky.) -
Simon Schaufelberger commented on patch set 6 05/29/22, 11:57
sure, I will do that. -
Simon Schaufelberger updated the commit message in patch set 7 05/29/22, 12:11
-
core-ci voted on patch set 7 V +1 05/29/22, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27547
-
Oliver Klee voted on patch set 7 V +1 CR +1 05/29/22, 12:21
-
Simon Schaufelberger uploaded patch set 8 05/29/22, 12:24
-
Oliver Klee voted on patch set 8 V +1 CR +1 05/29/22, 12:26
-
core-ci voted on patch set 8 V +1 05/29/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27548
-
Simon Schaufelberger uploaded patch set 9 05/29/22, 16:35
-
core-ci voted on patch set 9 V +1 05/29/22, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27554
-
Oliver Klee commented on patch set 9 05/29/22, 17:12
DataHandler.php:994To allow for XCLASSing, you‘ll need to use static::class instead. -
Simon Schaufelberger uploaded patch set 10 05/29/22, 17:20
-
Simon Schaufelberger commented on patch set 10 05/29/22, 17:20
DataHandler.php:994ReplyDone -
Oliver Klee voted on patch set 10 V +1 CR +1 05/29/22, 17:22
-
core-ci voted on patch set 10 V -1 05/29/22, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27557
-
Simon Schaufelberger commented on patch set 10 05/29/22, 17:46
Any idea why phpstan is not able to read "registerDBList"? "Access to an undefined property object::$registerDBList." The other properties before like "copyMappingArray" work. With the annotation of $tce as DataHandler it works. -
Oliver Klee voted on patch set 10 V 0 CR 0 05/29/22, 18:01
-
Simon Schaufelberger uploaded patch set 11 05/29/22, 18:57
-
Simon Schaufelberger commented on patch set 10 05/29/22, 18:59
Reply
This issue looks like a phpstan bug because if I move the line to line 1008 outside the "if" then the error is gone but that "if" statement has no direct influence on registerDBList. This is really strange. Let me add the type hint again to fix that bug. -
core-ci voted on patch set 11 V +1 05/29/22, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27561
-
Oliver Klee voted on patch set 11 V +1 CR +1 05/29/22, 20:08
-
Stefan Bürk commented on patch set 11 CR -1 05/30/22, 07:15
AddController.php:198That's not needed - this annotation comment can be removed completly. This is covered by `.phpstorm.meta.php`, and for phpstan it seems to make no difference. We may have to take care of the phptan-typo3 package and extend it more - but that's another point.AbstractFormElementTest.php:278This is okay and handled properly by phpstan. However, for phpstorm this now removes the intersection with "AbstractFormElement". It seems, that PHPStorm do not pickup the `@template T of object` and `@return MockObject&AccessibleObjectInterface&T` properly ... eventually because of overruling by native type which lacks this. @Oliver may you have a look as you have changed this in TF - is there a way for PHPstorm also ? otherwise we still "needs" these annotation comments for IDE - or not ? Even if we do not use psalm, maybe we should use psalm types ? ``` // e.g. from phpunit /** * Returns a mock object for the specified class. * * @psalm-template RealInstanceType of object * @psalm-param class-string<RealInstanceType> $originalClassName * @psalm-return MockObject&RealInstanceType */ protected function createMock(string $originalClassName): MockObject { return $this->createMockObject($originalClassName); } ```InlineStackProcessorTest.php:272InlineStackProcessorTest.php:285InlineStackProcessorTest.php:297NodeFactoryTest.php:286DataHandler.php:994Changed this back to DataHandler -- no difference in baseline. So, what does the comment addition mean ? Why does phpstan require this and why should this be a phpstan bug ? If it is a bug, have we reported it with a proper example to phpstan ? Or whas this meant, if the comment is dropped at all ? Eventually this can be extended in the friendsoftypo3/phpstan-typo3 pacakge for GeneralUtilitiy::makeInstance() to properly return the correct return type than and introduce this to phpstan (and thus not a real bug in phptan).ListUtility.php:31If doctype is changed, should we not make return as proper array shape ? ``` array<non-empty-string, Folder> ``` @Oliver what is your opinion on that ? -
Oliver Klee commented on patch set 11 05/30/22, 10:08
ListUtility.php:31ReplyHaha, I already tried that and changed it back. :-) Yes, that is the right thing to do (and I'd be willing to do this). However, we should do this in a separate change as this then get PHPStan to discover that can should simplify the caller(s) (which I consider to be out of scope of this change). -
Simon Schaufelberger commented on patch set 11 05/30/22, 15:37
DataHandler.php:994ReplyThe problem is this "if" in line 1008. Accessing a property of $tce won't work there for some reason. If you move the line "$registerDBList = array_merge($registerDBList, $tce->registerDBList);" before the "if", it works but the if doesn't check anything about "$tce->registerDBList" so why does this "if" make a difference? That is not clear for me and this seems like a bug in phpstan or what would you expect? -
Simon Schaufelberger uploaded patch set 12 05/30/22, 15:52
-
Simon Schaufelberger commented on patch set 12 05/30/22, 15:53
AddController.php:198ReplyDoneInlineStackProcessorTest.php:285Replythis subject can never be something else than InlineStackProcessor so why does it have this wrong annotation? -
core-ci voted on patch set 12 V +1 05/30/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27588
-
Oliver Klee commented on patch set 12 05/31/22, 10:36
AbstractFormElementTest.php:278ReplyUnfortunately, I currently do not know enough about how to get PHPStorm to understand this (or what it currently already understands). In general, my educated guess is that Psalm-specific annotations won't help much - AFAIK PHPStorm understand them the same way it understands PHPStan-specific annotations. (And I'd like to avoid having Psalm-specific things in our code when we are using PHPStan for static analysis.)ListUtility.php:31ReplyI have now entered a ticket so this won't get lost (and I will take care of it after this change has been merged): https://forge.typo3.org/issues/97711 -
Oliver Klee voted on patch set 12 V +1 05/31/22, 13:10
-
Oliver Klee voted on patch set 12 CR +1 05/31/22, 13:11
-
Oliver Klee commented on patch set 12 06/01/22, 10:20
DataHandler.php:995Just talked to Stefan: This should be self::class (also the other place). I will try whether we can remove the annotation now. -
Oliver Klee voted on patch set 12 CR 0 06/01/22, 10:25
-
Oliver Klee commented on patch set 12 06/03/22, 19:39
I'll (hopefully) do this on Monday. -
Oliver Klee commented on patch set 12 06/06/22, 14:49
AbstractFormElementTest.php:278ReplyDoneInlineStackProcessorTest.php:272ReplyDoneInlineStackProcessorTest.php:285ReplyDoneInlineStackProcessorTest.php:297ReplyDoneNodeFactoryTest.php:286ReplyDoneDataHandler.php:994ReplyDoneDataHandler.php:995ReplyDoneImageMagickFileTest.php:345ReplyDone -
Oliver Klee uploaded patch set 13 06/06/22, 14:49
-
Oliver Klee voted on patch set 13 CR +1 06/06/22, 14:52
-
Oliver Klee voted on patch set 13 V +1 06/06/22, 14:53
-
core-ci voted on patch set 13 V -1 06/06/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27727
-
Oliver Klee commented on patch set 13 06/06/22, 15:08
The build failure is the flaky acceptance test AFAICS. -
core-ci voted on patch set 13 V +1 06/06/22, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27727
-
Stefan Bürk rebased onto patch set 14 06/06/22, 19:30
-
core-ci voted on patch set 14 V +1 06/06/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27744
-
Oliver Klee voted on patch set 14 V +1 CR +1 06/06/22, 19:42
-
Simon Schaufelberger commented on patch set 14 06/06/22, 20:15
ListUtility.php:39can be dropped. -
Simon Schaufelberger uploaded patch set 15 06/06/22, 20:24
-
Simon Schaufelberger commented on patch set 14 06/06/22, 20:24
ListUtility.php:39ReplyDone -
Simon Schaufelberger uploaded patch set 16 06/06/22, 20:29
-
core-ci voted on patch set 16 V +1 06/06/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27752
-
core-ci voted on patch set 15 V +1 06/06/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27751
-
Oliver Klee voted on patch set 16 V +1 CR +1 06/06/22, 20:53
-
Stefan Bürk voted on patch set 16 V +2 CR +2 06/07/22, 16:04
-
Stefan Bürk merged patch set 17 06/07/22, 16:04