Review 11.5 Merged

74787[TASK] Remove type annotations where possible

Simon Schaufelberger CR +2 V +2 Expert +97 −914 updated 06/07/22, 16:04

Commit message

Searched for "/** @var " and went through all results manually.
Skipped results where GeneralUtility::makeInstance is called with
a variable.

This reduces the PHPStan baseline further.

Imported some namespaces on the go.

Run commands:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline
> Build/Scripts/runTests.sh -s cglGit

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 275

Show 255 more files

Review log 1727

Show 12 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 05/29/22, 13:46

  2. core-ci voted on patch set 1 V -1 05/29/22, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27551

  1. Simon Schaufelberger uploaded patch set 2 05/29/22, 14:16

  2. core-ci voted on patch set 2 V +1 05/29/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27552

  3. Oliver Klee voted on patch set 2 V +1 05/29/22, 15:50

  4. Simon Schaufelberger uploaded patch set 3 05/29/22, 16:54

  5. core-ci voted on patch set 3 V +1 05/29/22, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27555

  6. Oliver Klee commented on patch set 3 05/29/22, 17:12

    DataHandler.php:1002

    To allow for XCLASSing, you‘ll need to use static::class instead.
  7. Simon Schaufelberger uploaded patch set 4 05/29/22, 17:22

  8. Simon Schaufelberger commented on patch set 4 05/29/22, 17:23

    DataHandler.php:1002 Reply

    Done
  9. core-ci voted on patch set 4 V -1 05/29/22, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27559

  10. Simon Schaufelberger uploaded patch set 5 05/29/22, 18:58

  11. core-ci voted on patch set 5 V +1 05/29/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27562

  12. Oliver Klee voted on patch set 5 V +1 05/29/22, 20:07

  13. Simon Schaufelberger uploaded patch set 6 06/06/22, 20:22

  14. core-ci voted on patch set 6 V -1 06/06/22, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27750

  15. Simon Schaufelberger uploaded patch set 7 06/06/22, 20:37

  16. Simon Schaufelberger uploaded patch set 8 06/06/22, 20:41

  17. Simon Schaufelberger rebased onto patch set 9 06/06/22, 20:43

  18. core-ci voted on patch set 7 V -1 06/06/22, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27753

  19. core-ci voted on patch set 8 V -1 06/06/22, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27754

  20. core-ci voted on patch set 9 V -1 06/06/22, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27755

  21. Simon Schaufelberger uploaded patch set 10 06/06/22, 21:04

  22. core-ci voted on patch set 10 V +1 06/06/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27756

  23. Oliver Klee voted on patch set 10 V +1 06/06/22, 21:12

  24. Stefan Bürk voted on patch set 10 V +2 CR +2 06/07/22, 16:04

  25. Stefan Bürk merged patch set 11 06/07/22, 16:04