Review 11.5 Merged

74791[TASK] Note nullable parameters and returns as such

Stefan Bürk CR +2 V +2 Normal +6 −46 updated 05/31/22, 07:46

Commit message

Based on the code, these parameters are nullable. The doc
comments should reflect that. Doing so eliminates several
PHPStan warnings.

Whether these parameters ought to be nullable is a question
for another time.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Stefan Bürk uploaded patch set 1 05/31/22, 07:38

  2. core-ci voted on patch set 1 V +1 05/31/22, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27592

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 05/31/22, 07:46

  4. Stefan Bürk merged patch set 2 05/31/22, 07:46