Review main Merged

74792[TASK] Update to PHPStan 1.8.0

Oliver Klee CR +2 V +2 Easy +9 −9 updated 07/01/22, 19:23

Commit message

Used commands:
> composer req --dev phpstan/phpstan:^1.8.0
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2235

Show 510 earlier messages
  1. Oliver Klee uploaded patch set 1 05/31/22, 09:51

  2. core-ci voted on patch set 1 V -1 05/31/22, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27593

  3. Oliver Klee uploaded patch set 2 05/31/22, 14:16

  4. core-ci voted on patch set 2 V +1 05/31/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27602

  5. Oliver Klee uploaded patch set 3 06/01/22, 14:00

  6. core-ci voted on patch set 3 V +1 06/01/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27622

  7. Oliver Klee uploaded patch set 4 06/02/22, 15:35

  8. core-ci voted on patch set 4 V +1 06/02/22, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27657

  9. Oliver Klee uploaded patch set 5 06/03/22, 14:27

  10. core-ci voted on patch set 5 V +1 06/03/22, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27685

  1. Oliver Klee uploaded patch set 6 06/09/22, 11:32

  2. core-ci voted on patch set 6 V +1 06/09/22, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27880

  3. Benni Mack commented on patch set 6 06/09/22, 15:28

    Now we're at 1.7.12
  4. Oliver Klee uploaded patch set 7 06/09/22, 15:33

  5. Oliver Klee commented on patch set 7 06/09/22, 15:34

    Reply

    Time flies (and so does PHPStan) … done.
  6. core-ci voted on patch set 7 V +1 06/09/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27896

  7. Oliver Klee uploaded patch set 8 06/17/22, 08:24

  8. core-ci voted on patch set 8 V -1 06/17/22, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28127

  9. core-ci voted on patch set 8 V +1 06/17/22, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28127

  10. Oliver Klee uploaded patch set 9 06/20/22, 10:09

  11. core-ci voted on patch set 9 V +1 06/20/22, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28250

  12. Oliver Klee uploaded patch set 10 06/24/22, 14:03

  13. core-ci voted on patch set 10 V +1 06/24/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28393

  14. Oliver Klee uploaded patch set 11 06/29/22, 10:47

  15. core-ci voted on patch set 11 V +1 06/29/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28480

  16. Simon Schaufelberger commented on patch set 11 07/01/22, 18:47

    Why is this still WIP?
  17. Oliver Klee commented on patch set 11 07/01/22, 18:59

    Because I‘m mainly keeping this long-living change updated to see whether a new PHPStan version brings any interesting changes that would warrant merging it. :-) (In other words, we can make this non-WIP and merge it once we think we actually need the update.)
  18. Christian Kuhn commented on patch set 11 07/01/22, 19:00

    Reply

    Done
  19. Christian Kuhn uploaded patch set 12 07/01/22, 19:01

  20. Christian Kuhn voted on patch set 12 V +1 CR +1 07/01/22, 19:01

  21. Simon Schaufelberger voted on patch set 12 V +1 CR +1 07/01/22, 19:03

  22. core-ci voted on patch set 12 V +1 07/01/22, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28599

  23. Christian Kuhn commented on patch set 12 07/01/22, 19:13

    @klee: let's get this minor raise in now, and backport. then let's only push new patches if they are really add value, otherwise skip. we don't need to always keep up with latest release of phpstan if it doesn't add value.
  24. Christian Kuhn voted on patch set 12 V +2 CR +2 07/01/22, 19:23

  25. Christian Kuhn merged patch set 13 07/01/22, 19:23