74793[BUGFIX] Fix randomly failing PageTreeFilterCest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2125
-
Simon Schaufelberger uploaded patch set 1 05/31/22, 11:40
-
core-ci voted on patch set 1 V +1 05/31/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27598
-
Jochen Roth commented on patch set 1 05/31/22, 11:54
In general, it’s better to wait for the expected element to appear instead of using just wait X seconds. This avoids timing issues in case the gitlab runner slower as usual. -
Simon Schaufelberger commented on patch set 1 05/31/22, 12:00
Reply
The problem here is that we use a filter, so the page tree will be there as soon as we click the "List" module. The strange thing is that in the screenshot (see Slack) the search term "Group" is not even in the input field. So a waitForElement won't help here much. -
Jochen Roth voted on patch set 1 V +1 CR +1 05/31/22, 12:05
-
Oliver Klee voted on patch set 1 V +1 05/31/22, 14:17
-
core-ci commented on patch set 1 05/31/22, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27604
-
Jonas Eberle voted on patch set 1 CR +1 06/01/22, 14:25
-
Jochen Roth wrote 06/02/22, 12:27
Removed Verified+1 by Jochen Roth -
Jochen Roth wrote 06/02/22, 12:27
Removed Code-Review+1 by Jochen Roth -
Stefan Bürk commented on patch set 1 CR -1 06/03/22, 17:25
To comment it - had a talk with Jochen. Jochen is working in it. Thus a temporarly -1 on it. -
Jochen Roth uploaded patch set 2 06/05/22, 20:42
-
core-ci voted on patch set 2 V +1 06/05/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27714
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 06/05/22, 21:03
-
Jochen Roth commented on patch set 2 06/05/22, 21:05
Still on it, will push a new and probably last version soonish -
Jochen Roth voted on patch set 2 CR -1 06/05/22, 22:04
-
Simon Schaufelberger wrote 06/05/22, 22:35
Removed Verified+1 by Simon Schaufelberger -
Simon Schaufelberger wrote 06/05/22, 22:35
Removed Code-Review+1 by Simon Schaufelberger -
Jochen Roth wrote 06/06/22, 18:31
Removed Code-Review-1 by Jochen Roth -
Jochen Roth commented on patch set 2 06/06/22, 18:32
Reply
Well, that didn't work. So i think i leave it as as. Feel free to vote -
Stefan Bürk updated the commit message in patch set 3 06/06/22, 18:39
-
core-ci voted on patch set 3 V +1 06/06/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27738
-
Oliver Klee voted on patch set 3 V +1 CR +1 06/06/22, 18:50
-
Stefan Bürk voted on patch set 3 V +2 CR +2 06/06/22, 19:03
-
Stefan Bürk merged patch set 4 06/06/22, 19:03