74794[TASK] Replace single quotes by double quotes in annotations
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1827
Show 02 earlier messages
-
TYPO3com uploaded patch set 1 05/31/22, 13:15
-
core-ci voted on patch set 1 V +1 05/31/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27600
-
Benni Mack commented on patch set 1 05/31/22, 20:40
-
Joey Bouten uploaded patch set 2 06/08/22, 13:08
-
Joey Bouten commented on patch set 2 CR +1 06/08/22, 13:09
Feature-91719-CustomErrorMessagesInRegularExpressionValidator.rst:51ReplyUpdated them. -
core-ci voted on patch set 2 V +1 06/08/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27818
-
Oliver Klee updated the commit message in patch set 3 06/08/22, 13:24
-
core-ci voted on patch set 3 V +1 06/08/22, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27820
-
Joey Bouten commented on patch set 3 06/08/22, 13:33
"It" twice in commit message. -
Oliver Klee updated the commit message in patch set 4 06/08/22, 13:42
-
Oliver Klee commented on patch set 4 06/08/22, 13:43
Reply
Done -
core-ci voted on patch set 4 V -1 06/08/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27821
-
core-ci voted on patch set 4 V +1 06/08/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27821
-
Oliver Klee wrote 06/09/22, 07:45
Removed cc Oliver Klee. -
Simon Schaufelberger commented on patch set 4 V +1 CR +1 06/17/22, 11:46
I had the same issue already with extbase annotations and can confirm that they MUST be double quotes. -
Oliver Klee voted on patch set 4 CR +1 06/17/22, 12:33
-
Christian Kuhn updated the commit message in patch set 5 06/18/22, 23:54
-
Simon Schaufelberger voted on patch set 5 V +1 CR +1 06/18/22, 23:55
-
Christian Kuhn commented on patch set 5 06/18/22, 23:55
thanks for the patch! just added 11.5 as merge target. -
Christian Kuhn voted on patch set 5 V +1 CR +1 06/18/22, 23:55
-
core-ci voted on patch set 5 V -1 06/19/22, 00:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28200
-
Christian Kuhn rebased onto patch set 6 06/19/22, 00:10
-
Simon Schaufelberger voted on patch set 6 V +1 CR +1 06/19/22, 00:15
-
core-ci voted on patch set 5 V -1 06/19/22, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28200
-
core-ci voted on patch set 6 V +1 06/19/22, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28204
-
Christian Kuhn voted on patch set 6 V +2 CR +2 06/19/22, 00:19
-
Christian Kuhn merged patch set 7 06/19/22, 00:19
Feature-91719-CustomErrorMessagesInRegularExpressionValidator.rst:51