74795[TASK] Set FlashMessageQueue for ModuleTemplate in extbase controller
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 9
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+1 −0
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/List.html+0 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/CompareGroups.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Groups.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+0 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+0 −1
Review log 67
-
Nikita Hovratov uploaded patch set 1 05/31/22, 14:15
-
core-ci voted on patch set 1 V +1 05/31/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27601
-
Benni Mack commented on patch set 1 05/31/22, 20:46
should we adapt the RST of a previous commit (or add a new one now?) that Extbase Backend Controller do not need to add this in their templates anymore? -
Nikita Hovratov commented on patch set 1 06/01/22, 06:40
Reply
well they still need it, if they don't use the ModuleTemplate or don't set the Flashmessage queue manually. If we do this, then probably here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73260 -
Christian Kuhn commented on patch set 1 V +1 CR +1 06/19/22, 00:58
that solution is fine: the additional VH calls that have been added with #97569 are useless since moduleTemplate has the VH call in the default layout already. Adapting moduletemplate to the extbase queue is the better solution. thx! -
Stefan Bürk voted on patch set 1 V +2 CR +2 06/19/22, 00:59
-
Stefan Bürk merged patch set 2 06/19/22, 00:59