Review main Merged

74795[TASK] Set FlashMessageQueue for ModuleTemplate in extbase controller

Nikita Hovratov CR +2 V +2 Easy +2 −7 updated 06/19/22, 00:59

Commit message

For the Module Template Layout to render FlashMessages, it
needs to hold the FlashMessageQueue with the added messages.
This needs to be done manually for extbase extensions, as
they are holding their own internal queue.

This patch also reverts the related patch #97569, which
fixed it by adding an explicit f:flashMessages VH to the
templates.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 67

  1. Nikita Hovratov uploaded patch set 1 05/31/22, 14:15

  2. core-ci voted on patch set 1 V +1 05/31/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27601

  3. Benni Mack commented on patch set 1 05/31/22, 20:46

    should we adapt the RST of a previous commit (or add a new one now?) that Extbase Backend Controller do not need to add this in their templates anymore?
  4. Nikita Hovratov commented on patch set 1 06/01/22, 06:40

    Reply

    well they still need it, if they don't use the ModuleTemplate or don't set the Flashmessage queue manually. If we do this, then probably here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73260
  5. Christian Kuhn commented on patch set 1 V +1 CR +1 06/19/22, 00:58

    that solution is fine: the additional VH calls that have been added with #97569 are useless since moduleTemplate has the VH call in the default layout already. Adapting moduletemplate to the extbase queue is the better solution. thx!
  6. Stefan Bürk voted on patch set 1 V +2 CR +2 06/19/22, 00:59

  7. Stefan Bürk merged patch set 2 06/19/22, 00:59