Review main Merged

74796[BUGFIX] Provide languageField in case it's missing

Henrik Elsner CR +2 V +2 Easy +7 −0 updated 07/05/23, 21:37

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 2532

Show 57 earlier messages
  1. Henrik Elsner uploaded patch set 1 05/31/22, 19:00

  2. core-ci voted on patch set 1 V -1 05/31/22, 19:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27605

  3. Henrik Elsner uploaded patch set 2 05/31/22, 19:36

  4. core-ci voted on patch set 2 V -1 05/31/22, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27606

  5. Benni Mack commented on patch set 2 05/31/22, 19:48

    PageRepository.php:20

    I don't think we need BackendUtility here...
  6. Henrik Elsner commented on patch set 2 05/31/22, 20:15

    PageRepository.php:20 Reply

    you're right.. im used to fixers cleaning this up :D Removed
  7. Henrik Elsner uploaded patch set 3 05/31/22, 20:15

  1. core-ci voted on patch set 3 V -1 05/31/22, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27607

  2. Henrik Elsner commented on patch set 3 05/31/22, 20:44

    PageRepository.php:20 Reply

    Done
  3. Simon Schaufelberger uploaded patch set 4 09/22/22, 00:24

  4. core-ci voted on patch set 4 V +1 09/22/22, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31403

  5. JAKOTA Design Group GmbH commented on patch set 4 09/22/22, 08:16

    PageRepository.php:653

    This feel like the wrong approach to this issue. Instead of fixing it by adding an additional database query, I think it would be better to fix the original query. By checking if the table has a languageField and adding it if is it missing from the selectFields parameter.
  6. Benni Mack commented on patch set 4 10/12/22, 18:17

    Hey Henrik, any recommendations here on how to proceed?

    PageRepository.php:20 Reply

    Done
  7. Henrik Elsner commented on patch set 4 10/12/22, 18:25

    Reply

    currently not, it's depending if we want to change the strategy as Jakota suggested?
  8. Benni Mack commented on patch set 4 10/17/22, 09:09

    Reply

    yes, but how did this happen in your case where you did not select the languageField? should we ensure that we always add the langugeFields in the DatabaseQueryProcessor? I guess this would be cObj->sanitizeSelectPart()
  9. JAKOTA Design Group GmbH uploaded patch set 5 V +1 03/20/23, 12:32

  10. JAKOTA Design Group GmbH commented on patch set 5 03/20/23, 12:59

    Reply

    This happens if the languageField was not provided with the selectFields parameter. Thanks for pointing me to the correct file to fix this issue. This also fixes the issue #97639 which I have linked to this patch.

    PageRepository.php:653 Reply

    Done
  11. core-ci voted on patch set 5 V +1 03/20/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39234

  12. Oliver Klee commented on patch set 5 03/20/23, 13:36

    ContentObjectRenderer.php:5536

    I propose to make this check more explicit: ```php if (is_string($languageField)) { ```
  13. JAKOTA Design Group GmbH uploaded patch set 6 V +1 03/20/23, 13:44

  14. JAKOTA Design Group GmbH commented on patch set 6 03/20/23, 13:45

    ContentObjectRenderer.php:5536 Reply

    Done
  15. core-ci voted on patch set 6 V +1 03/20/23, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39239

  16. Benni Mack voted on patch set 6 CR +1 03/21/23, 09:32

  17. Oliver Klee voted on patch set 6 CR +1 03/21/23, 09:34

  18. Benni Mack updated the commit message in patch set 7 CR +1 V +1 05/03/23, 09:38

  19. Benni Mack voted on patch set 7 V +1 CR +1 05/03/23, 09:38

  20. Benni Mack rebased onto patch set 8 CR +1 V +1 07/04/23, 20:29

  21. core-ci voted on patch set 8 V +1 07/04/23, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43438

  22. Benni Mack voted on patch set 8 V +1 CR +1 07/05/23, 19:22

  23. Susi Moog voted on patch set 8 V +1 CR +1 07/05/23, 21:22

  24. Benni Mack voted on patch set 8 V +2 CR +2 07/05/23, 21:37

  25. Benni Mack merged patch set 9 07/05/23, 21:37