Review main Merged

74799[BUGFIX] Ensure proper value when accessing array

Marc Willmann CR +2 V +2 Easy +1 −1 updated 06/03/22, 16:34

Commit message

Even if the property 'crop' is not explicit set in the
TypoScript code provide expected values to the stdWrap
method (which expects a string and not NULL).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Jan Helke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jan Helke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Marc Willmann uploaded patch set 1 06/01/22, 11:07

  2. core-ci voted on patch set 1 V +1 06/01/22, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27616

  3. Oliver Klee voted on patch set 1 CR +1 06/01/22, 11:20

  4. Jan Helke voted on patch set 1 V +1 CR +1 06/01/22, 11:46

  5. Simon Schaufelberger voted on patch set 1 V +1 CR +1 06/01/22, 12:38

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 06/03/22, 16:34

  7. Stefan Bürk merged patch set 2 06/03/22, 16:34