Review main Merged

74800[TASK] Raise to recent composer/composer 2.2 version

Oliver Hader CR +2 V +2 Easy +8 −8 updated 06/02/22, 11:23

Commit message

composer req --dev composer/composer:^2.2.12

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Oliver Hader uploaded patch set 1 06/01/22, 14:12

  2. Oliver Klee voted on patch set 1 CR +1 06/01/22, 14:14

  3. Oliver Hader updated the commit message in patch set 2 06/01/22, 14:15

  4. Oliver Klee voted on patch set 2 CR +1 06/01/22, 14:16

  5. core-ci voted on patch set 1 V +1 06/01/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27624

  6. core-ci voted on patch set 2 V +1 06/01/22, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27626

  7. Oliver Klee voted on patch set 2 V +1 06/01/22, 14:27

  8. Oliver Klee commented on patch set 2 CR 0 06/01/22, 14:29

    The latest 2.2.x version is 2.2.13. Should we directly use that? https://packagist.org/packages/composer/composer#2.2.13
  9. Oliver Hader commented on patch set 2 06/01/22, 15:30

    Reply

    Implicitly that's the case in the lock-file... however, I'd keep it like that (.12) in the json-file.
  10. Oliver Klee commented on patch set 2 06/01/22, 15:33

    Reply

    Any particular reason why?
  11. Oliver Hader commented on patch set 2 06/01/22, 16:29

    Reply Unresolved

    No
  12. Oliver Hader voted on patch set 2 V +2 CR +2 06/02/22, 11:23

  13. Oliver Hader merged patch set 3 06/02/22, 11:23