Review 11.5 Merged

74803[TASK] Raise to recent moment & moment-timezone versions

Oliver Hader CR +2 V +2 Easy +8 −8 updated 06/03/22, 10:06

Commit message

+ npm package moment up to v2.29.2 contained a vulnerability
  (https://github.com/advisories/GHSA-8hfj-j24r-96c4) which only
  affected npm server users - in order to avoid confusion concerning
  security aspects, the package version is raised
+ npm package moment-timezone was upgraded to recent timezone data
  "IANA TZDB 2021"

Executed commands:

cd Build; \
  nvm use; \
  yarn upgrade moment moment-timezone; \
  yarn exec grunt clear-build; \
  yarn exec grunt build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Hader uploaded patch set 1 06/01/22, 15:03

  2. core-ci voted on patch set 1 V +1 06/01/22, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27629

  3. Oliver Hader updated the commit message in patch set 2 06/01/22, 16:31

  4. core-ci voted on patch set 2 V +1 06/01/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27633

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 06/02/22, 22:10

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 06/03/22, 10:05

  7. Andreas Kienast merged patch set 3 06/03/22, 10:06