Review main Merged

74805[BUGFIX] Use moment.unix for visualizing regular unix timestamps

Oliver Hader CR +2 V +2 Easy +3 −3 updated 06/10/22, 12:25

Commit message

A dialog trying to prevent overriding existing files in the filelist
module shows an incorrect modification date of files that are existing
on the server-side. When using regular unix timestamps (instead of
micro-timestamps), dedicated `moment.unix` function has to be used.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1418

  1. Oliver Hader uploaded patch set 1 06/01/22, 15:26

  2. core-ci voted on patch set 1 V +1 06/01/22, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27631

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/01/22, 15:51

  4. Simon Schaufelberger commented on patch set 1 CR -1 06/01/22, 16:24

    moment, not momment
  5. Oliver Hader updated the commit message in patch set 2 06/01/22, 16:32

  6. Oliver Hader commented on patch set 2 06/01/22, 16:32

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/01/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27635

  8. Simon Schaufelberger voted on patch set 2 V +1 CR +1 06/02/22, 22:13

  9. Simon Schaufelberger commented on patch set 2 06/02/22, 22:15

    Isn't this actually a bugfix?
  10. Andreas Kienast uploaded patch set 3 06/03/22, 09:59

  11. core-ci voted on patch set 3 V +1 06/03/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27674

  12. Oliver Hader updated the commit message in patch set 4 06/03/22, 13:59

  13. core-ci voted on patch set 4 V +1 06/03/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27683

  14. Stefan Bürk commented on patch set 4 V +1 CR +1 06/03/22, 17:05

    Reply

    Done
  15. Simon Schaufelberger voted on patch set 4 V +1 CR +1 06/04/22, 00:21

  16. Benni Mack voted on patch set 4 V +1 CR +1 06/07/22, 21:02

  17. Andreas Kienast voted on patch set 4 V +2 CR +2 06/10/22, 12:25

  18. Andreas Kienast merged patch set 5 06/10/22, 12:25