Review 11.5 Merged

74808[TASK] Improve a type annotation in the setup extension

Stefan Bürk CR +2 V +2 Easy +3 −14 updated 06/02/22, 11:40

Commit message

Also add a missing type cast.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 06/02/22, 11:30

  2. core-ci voted on patch set 1 V +1 06/02/22, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27656

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/02/22, 11:40

  4. Stefan Bürk merged patch set 2 06/02/22, 11:40