Review main Merged Breaking

74811[!!!][FEATURE] Respect attribute "approved" when parsing XLIFF files

Georg Ringer CR +2 V +2 Normal +138 −29 updated 10/02/22, 20:38

Commit message

By supporting the `approved` attribute, integrators can decide
whether translations not marked as approved should be used. This
attribute is particularly useful when working with third-party
software and translation agencies. Allowing unapproved translations
may increase the number of translations, possibly at the expense of
their quality.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 4356

Show 2331 earlier messages
  1. Georg Ringer uploaded patch set 1 06/03/22, 07:05

  2. core-ci voted on patch set 1 V +1 06/03/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27667

  3. Georg Ringer commented on patch set 1 06/03/22, 08:22

    This change is ready for review.
  4. Mathias Brodala commented on patch set 1 06/03/22, 09:25

    DefaultConfiguration.php:264

    To avoid the usual TYPO3-thing of "enable to disable" or "disable to enable" this should be named "requireApprovedLocalizations" and default to "true".
  5. Stephan Großberndt commented on patch set 1 06/03/22, 09:26

    We only used approved in communication of language files with translation agencies years ago. For a long time in our extensions the approved attributes have been removed. It still might be there are extensions with locallang labels having approved="no" attributes where after the patch the translations would vanish after a minor v11 update. Thus I consider this breaking and would opt to do this in main/v12 only.
  6. Georg Ringer commented on patch set 1 06/03/22, 09:34

    DefaultConfiguration.php:264 Reply

    thanks for the idea, will do
  7. Georg Ringer commented on patch set 1 06/03/22, 09:36

    Reply

    as crowdin can be configured on a branch level if non approved can be exported as well, there is no need to backport that into 11 ;)
  8. Georg Ringer uploaded patch set 2 06/07/22, 18:41

  9. core-ci voted on patch set 2 V -1 06/07/22, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27774

  10. Georg Ringer uploaded patch set 3 06/07/22, 18:53

  11. core-ci voted on patch set 3 V +1 06/07/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27775

  12. Markus Klein commented on patch set 4 06/07/22, 19:08

    Published edit on patch set 3.
  13. core-ci voted on patch set 4 V +1 06/07/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27776

  14. Stephan Großberndt commented on patch set 4 CR -1 06/08/22, 10:58

    DefaultConfiguration.php:264 Reply

    Done

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:14

    whether

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:14

    Must be yes or no instead of true or false

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:25

    `yes`

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:25

    set
  15. Stephan Großberndt voted on patch set 4 CR +1 06/08/22, 11:07

  16. Stephan Großberndt commented on patch set 5 06/08/22, 11:07

    Published edit on patch set 4.
  17. Stephan Großberndt voted on patch set 5 CR +1 06/08/22, 11:07

  18. Stephan Großberndt commented on patch set 5 06/08/22, 11:08

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:14 Reply

    Done

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:14 Reply

    Done

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:25 Reply

    Done

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:25 Reply

    Done
  19. core-ci voted on patch set 5 V +1 06/08/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27804

  20. André Buchmann voted on patch set 5 V +1 CR +1 06/11/22, 20:00

  21. Stefan Bürk updated the commit message in patch set 6 06/17/22, 04:21

  22. core-ci voted on patch set 6 V -1 06/17/22, 04:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28120

  23. Stefan Bürk rebased onto patch set 7 06/17/22, 07:19

  24. core-ci voted on patch set 7 V +1 06/17/22, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28124

  25. Stephan Großberndt voted on patch set 7 CR +1 06/17/22, 07:30

  26. Andreas Kienast commented on patch set 7 CR -1 06/17/22, 08:32

    XliffParser.php:48

    Could be changed to `!$requireApprovedLocalizations || $approved === 'yes'`

    XliffParser.php:71

    Could be changed to `!$requireApprovedLocalizations || $approved === 'yes'`

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:6

    Please use a human-readable title. Also, the subject itself does not summarize what's breaking here.

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:6

    Please use a human-readable title
  27. Georg Ringer uploaded patch set 8 06/20/22, 13:40

  28. core-ci voted on patch set 8 V +1 06/20/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28266

  29. Stephan Großberndt commented on patch set 8 CR -1 06/20/22, 13:51

    By rebasing you apparently reverted my corrections to the changelog files
  30. Andreas Kienast commented on patch set 8 CR -1 06/20/22, 14:56

    My comments still apply
  31. Georg Ringer uploaded patch set 9 06/21/22, 04:44

  1. core-ci voted on patch set 9 V +1 06/21/22, 04:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28285

  2. Stephan Großberndt commented on patch set 9 06/21/22, 07:07

    XliffParser.php:48 Reply

    Done

    XliffParser.php:71 Reply

    Done

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:6 Reply

    Done

    Feature-97729-SupportAttributeApprovedInXlfFiles.rst:6 Reply

    Done
  3. Stephan Großberndt commented on patch set 10 06/21/22, 07:11

    Published edit on patch set 9.
  4. Stephan Großberndt voted on patch set 10 CR +1 06/21/22, 07:12

  5. core-ci voted on patch set 10 V +1 06/21/22, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28290

  6. André Buchmann voted on patch set 10 V +1 CR +1 06/22/22, 05:46

  7. Benni Mack commented on patch set 10 09/30/22, 22:49

    DefaultConfiguration.php:264

    should we move this to TYPO3_CONF_VARS[SYS][lang] ?
  8. Georg Ringer commented on patch set 10 10/01/22, 19:41

    @benni i am fine with it, which also means it can't be changed withhin the install tool, correct?
  9. Benni Mack commented on patch set 10 10/02/22, 08:01

    Reply

    yes, for the time being, but we could extend the install tool thingy later-on, OK? Naming now is more important than the install tool being editable.
  10. Benni Mack uploaded patch set 11 10/02/22, 10:15

  11. core-ci voted on patch set 11 V +1 10/02/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31865

  12. Benni Mack voted on patch set 11 CR +1 10/02/22, 10:30

  13. Benni Mack commented on patch set 11 10/02/22, 10:49

    DefaultConfiguration.php:264 Reply

    Done
  14. Kevin Appelt voted on patch set 11 CR +1 10/02/22, 11:18

  15. Oliver Hader commented on patch set 11 10/02/22, 16:57

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:14

    I guess the breaking behavior should be mentioned here, e.g. "... the corresponding setting is enabled per default, thus only approved translations are used."
  16. Oliver Hader uploaded patch set 12 10/02/22, 17:07

  17. Oliver Hader voted on patch set 12 V +1 CR +1 10/02/22, 17:07

  18. core-ci voted on patch set 12 V +1 10/02/22, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31897

  19. Kevin Appelt voted on patch set 12 CR +1 10/02/22, 17:23

  20. Georg Ringer voted on patch set 12 V +1 CR +1 10/02/22, 17:35

  21. Benni Mack commented on patch set 13 10/02/22, 18:58

    Published edit on patch set 12.
  22. Benni Mack commented on patch set 13 V +1 CR +1 10/02/22, 18:59

    Breaking-97729-SupportAttributeApprovedInXlfFiles.rst:14 Reply

    Done
  23. core-ci voted on patch set 13 V +1 10/02/22, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31908

  24. Oliver Hader voted on patch set 13 V +2 CR +2 10/02/22, 20:38

  25. Oliver Hader merged patch set 14 10/02/22, 20:38