74814[TASK] Add functional tests for indexed_search
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3851
Show 1926 earlier messages
-
Florian Schöppe uploaded patch set 1 06/03/22, 13:29
-
Oliver Klee updated the commit message in patch set 2 06/03/22, 13:30
-
Oliver Klee commented on patch set 2 CR -1 06/03/22, 13:31
We still need the ticket ID (in the "Resolves: #xxxxx" line), and the target releases (e.g., "Releases: main, 11.5). -
core-ci voted on patch set 1 V -1 06/03/22, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27675
-
Florian Schöppe commented on patch set 2 06/03/22, 13:37
Reply
Thanks for the quick reply. Forgot about the target releases, will add that in a second. I created this patch as suggested by Tymoteusz here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74688/comments/76a3f7b3_3d857c48 So I don't have a ticket ID!? -
core-ci voted on patch set 2 V -1 06/03/22, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27676
-
Oliver Klee updated the commit message in patch set 3 06/03/22, 13:42
-
Oliver Klee commented on patch set 3 06/03/22, 13:43
Reply
Now you have one: https://forge.typo3.org/issues/97732 :-) (I've updated the commit message accordingly.) -
core-ci voted on patch set 3 V -1 06/03/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27677
-
Florian Schöppe uploaded patch set 4 06/03/22, 13:57
-
Florian Schöppe commented on patch set 4 06/03/22, 14:00
Reply
Thank you! -
core-ci voted on patch set 4 V +1 06/03/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27681
-
Oliver Klee voted on patch set 4 V +1 06/03/22, 14:15
-
Stefan Bürk commented on patch set 4 06/03/22, 17:20
IndexerTestConfiguration.php:18Nice, test fixture class in Fixtures subfolder. May I ask if we can have a further subfolder here ? Fixtures/Configurations ? with proper added to the class namespace then ? -
Florian Schöppe uploaded patch set 5 06/06/22, 06:31
-
Florian Schöppe commented on patch set 5 06/06/22, 06:32
IndexerTestConfiguration.php:18ReplyDone -
core-ci voted on patch set 5 V +1 06/06/22, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27719
-
Oliver Klee voted on patch set 5 V +1 06/06/22, 08:58
-
Simon Schaufelberger commented on patch set 5 CR -1 06/07/22, 10:04
IndexSearchRepositoryTest.php:75this should be the first method as it applies for all methodsIndexerTest.php:40this can be rewritten with fnIndexerTest.php:49this can be rewritten with fn -
Stefan Bürk commented on patch set 5 CR -1 06/07/22, 10:29
on it -
Stefan Bürk uploaded patch set 6 06/07/22, 10:30
-
Stefan Bürk commented on patch set 6 06/07/22, 10:30
IndexSearchRepositoryTest.php:75ReplyDoneIndexerTest.php:40ReplyDoneIndexerTest.php:49ReplyDone -
Stefan Bürk commented on patch set 6 CR -1 06/07/22, 10:32
still on it ... -
core-ci voted on patch set 6 V +1 06/07/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27767
-
Stefan Bürk commented on patch set 6 06/07/22, 10:46
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/27769 -
core-ci commented on patch set 6 06/07/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27769
-
Stefan Bürk uploaded patch set 7 06/07/22, 11:09
-
core-ci voted on patch set 7 V +1 06/07/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27770
-
Oliver Klee voted on patch set 7 V +1 06/07/22, 11:24
-
Stefan Bürk voted on patch set 7 V +1 CR +1 06/07/22, 16:07
-
Stefan Bürk voted on patch set 7 V 0 CR 0 06/19/22, 02:06
-
Stefan Bürk commented on patch set 7 CR -1 06/27/22, 10:47
Thanks for the test. Lolli and I had reviewed that in our last minor merge/review "party". We/I will rework the tests to be more "useful" and making more obious checks which makes clearer what happens and avoiding unneded/superflous abstraction. -
Simon Schaufelberger rebased onto patch set 8 08/03/22, 21:19
-
Simon Schaufelberger wrote 08/03/22, 21:23
Removed reviewer Simon Schaufelberger. -
core-ci voted on patch set 8 V +1 08/03/22, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29807
-
Benni Mack rebased onto patch set 9
V +103/23/23, 13:19 -
core-ci voted on patch set 9 V -1 03/23/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39474
-
Oliver Klee commented on patch set 10
V -103/23/23, 16:17Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 03/23/23, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39483
-
Benni Mack updated the commit message in patch set 11
V +103/23/23, 22:30 -
core-ci voted on patch set 11 V +1 03/23/23, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39501
-
Christian Kuhn commented on patch set 11 03/24/23, 11:18
IndexSearchRepositoryTest.php:82$this->get() should work here. -
Benni Mack updated the commit message in patch set 12
V +105/03/23, 09:40 -
Stefan Bürk commented on patch set 12 CR -1 07/05/23, 09:20
on it ... -
Stefan Bürk uploaded patch set 13
CR -107/05/23, 11:15 -
Stefan Bürk commented on patch set 13 07/05/23, 11:18
IndexSearchRepositoryTest.php:82ReplyNot really .. not checked further. The repository is nowhere injected. Would leave that out for now and change this in a general indexed search di rount afterwards, if this is okay for you. -
Stefan Bürk commented on patch set 13 07/05/23, 11:26
IndexSearchRepositoryTest.php:82ReplyDone -
core-ci voted on patch set 13 V +1 07/05/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43491
-
Benni Mack commented on patch set 13 V +1 CR +1 07/05/23, 11:48
looks good -
Stefan Bürk voted on patch set 13 V +2 CR +2 07/05/23, 12:27
-
Stefan Bürk merged patch set 14 07/05/23, 12:27