Review main Merged

74822[TASK] Drop PhpStorm meta configuration for getAccessibleMock & friends

Oliver Klee CR +2 V +2 Easy +0 −4 updated 06/06/22, 17:56

Commit message

This is now covered by the annotations using generics in the testing
framework base class, and hence not needed anymore.

(Removing it also helps get consistent behavior from PhpStorm's
static type analysis.)

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oliver Klee uploaded patch set 1 06/06/22, 15:25

  2. core-ci voted on patch set 1 V -1 06/06/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27728

  3. Oliver Klee commented on patch set 1 06/06/22, 15:40

    The CI failure is the flaky acceptance test.
  4. core-ci voted on patch set 1 V +1 06/06/22, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27728

  5. Simon Schaufelberger voted on patch set 1 V +1 CR +1 06/06/22, 17:15

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 06/06/22, 17:56

  7. Stefan Bürk merged patch set 2 06/06/22, 17:56