74828[BUGFIX] Work around type issues in Fluid
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Vanessa Räbiger +1
- Felix P. +1
- Henning Liebe +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Vanessa Räbiger +1
- Felix P. +1
- Henning Liebe +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1415
-
crell uploaded patch set 1 06/07/22, 22:43
-
core-ci voted on patch set 1 V +1 06/07/22, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27784
-
Christian Kuhn commented on patch set 1 06/07/22, 22:59
mmmh. let's better fix upstream. there are a couple of things fixed in fluid-main that will happify cores phpstan a bit more with next release. -
Christian Kuhn commented on patch set 1 06/07/22, 23:03
or at least fix in fluid, too? -
crell commented on patch set 1 06/07/22, 23:06
Reply
Given the context of this code, I think doing both is a fine answer. (Since even without the type issue, calling getAttribute() right after getAttributes() is pointless.) -
Simon Schaufelberger voted on patch set 1 V +1 CR +1 06/20/22, 10:12
-
Nikita Hovratov commented on patch set 1 06/24/22, 07:20
no backport v11? -
Felix P. voted on patch set 1 V +1 CR +1 06/24/22, 09:53
-
Henning Liebe voted on patch set 1 V +1 CR +1 06/24/22, 13:02
-
Vanessa Räbiger voted on patch set 1 V +1 CR +1 06/24/22, 13:43
-
Stefan Bürk commented on patch set 1 06/24/22, 17:12
@larry: Maybe worth creating an issue at: https://github.com/TYPO3/Fluid/issues ? Would you take care of it in general ? (Would be up to @lolli/mbrodala to decide there then) -
crell commented on patch set 1 06/27/22, 16:58
Reply
Looks like it's already been fixed upstream: https://github.com/TYPO3/Fluid/blob/main/src/Core/ViewHelper/TagBuilder.php#L151 I still think this is a useful optimization here, though. -
Stefan Bürk voted on patch set 1 V +2 CR +2 07/07/22, 19:49
-
Stefan Bürk commented on patch set 1 07/07/22, 19:51
Normally not worth to mentioned it. This is normally such a small fraction in a request, even if it is technical correct. Not taking cached FE paged into account. Should only be mentioned if it is a real gain. -
Stefan Bürk merged patch set 2 07/07/22, 19:51