Review 11.5 Merged

74836[TASK] Resolve more dead code paths

Nikita Hovratov CR +2 V +2 Easy +5 −25 updated 06/09/22, 09:24

Commit message

More code paths identified as dead by PHPStan, or
that PHPStan isn't understanding correctly.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Jeroen Schutte +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Nikita Hovratov commented on patch set 1 06/09/22, 07:31

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. core-ci voted on patch set 1 V -1 06/09/22, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27856

  3. Stefan Bürk uploaded patch set 2 06/09/22, 08:33

  4. Stefan Bürk marked it ready for review 06/09/22, 08:34

  5. core-ci voted on patch set 2 V +1 06/09/22, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27861

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 06/09/22, 08:42

  7. Nikita Hovratov voted on patch set 2 V +2 CR +2 06/09/22, 08:43

  8. Nikita Hovratov merged patch set 3 06/09/22, 08:43

  9. Jeroen Schutte voted on patch set 3 CR +1 06/09/22, 09:24