Review main Merged

74863[BUGFIX] Always call GU::intExplode with a string in EXT:core

Oliver Klee CR +2 V +2 Easy +21 −20 updated 06/19/22, 01:52

Commit message

This helps avoid breakage when GeneralUtility will switch to
strict mode.

This change also prevents a whole bunch of possible invalid
array access warnings.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 56

  1. Oliver Klee uploaded patch set 1 06/09/22, 11:49

  2. core-ci voted on patch set 1 V +1 06/09/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27883

  3. Oliver Klee commented on patch set 1 06/09/22, 12:42

    How to verify: Check that https://review.typo3.org/c/Packages/TYPO3.CMS/+/74572 (that also has these changes and marks GU as strict) has a green build. (I will create more changes for the corresponding fixes in the other extensions before marking GU as strict.)
  4. Christian Kuhn commented on patch set 1 V +1 CR +1 06/19/22, 01:52

    GraphicalFunctions.php:1082

    lol.
  5. Stefan Bürk voted on patch set 1 V +2 CR +2 06/19/22, 01:52

  6. Stefan Bürk merged patch set 2 06/19/22, 01:52