Review main Merged

74869[TASK] Add support for PHP8.2 to Build/Scripts/runTests.sh

Stefan Bürk CR +2 V +2 Easy +12 −4 updated 06/10/22, 20:52

Commit message

This patch adds the ability to run commands with PHP8.2 using
`Build/Scripts/runTests.sh`. Support is added early to check
which issues may raise up with new major PHP version.

Help text of script is adopted to state the possibility of the
new PHP version with proper example commands. Additionally, a
note and check for currently not supported xdebug with PHP8.2
is added.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Stefan Bürk uploaded patch set 1 06/10/22, 14:42

  2. core-ci voted on patch set 1 V +1 06/10/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27928

  3. Stefan Bürk updated the commit message in patch set 2 06/10/22, 14:57

  4. core-ci voted on patch set 2 V +1 06/10/22, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27929

  5. Christian Kuhn commented on patch set 2 06/10/22, 16:58

    let's not add this stuff to the examples. other than that: fine with me.

    runTests.sh:263

    let's skip that ... those are examples and there is no need to have it 'complete'. users should read and compile the combinations they need.

    runTests.sh:277

    similar as above: let's not clutter example help section too much.

    runTests.sh:456

    nice! thx.
  6. Stefan Bürk uploaded patch set 3 06/10/22, 19:07

  7. Stefan Bürk commented on patch set 3 06/10/22, 19:13

    runTests.sh:263 Reply

    Done

    runTests.sh:277 Reply

    Done

    runTests.sh:456 Reply

    thx.
  8. core-ci voted on patch set 3 V -1 06/10/22, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27948

  9. core-ci voted on patch set 3 V +1 06/10/22, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27948

  10. Simon Schaufelberger voted on patch set 3 CR +1 06/10/22, 19:53

  11. Nikita Hovratov uploaded patch set 4 06/10/22, 20:41

  12. Nikita Hovratov voted on patch set 4 V +1 CR +1 06/10/22, 20:41

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 06/10/22, 20:44

  14. core-ci voted on patch set 4 V +1 06/10/22, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27953

  15. Stefan Bürk voted on patch set 4 V +2 CR +2 06/10/22, 20:52

  16. Stefan Bürk merged patch set 5 06/10/22, 20:52