Review main Merged

74871[TASK] Avoid failing test value for PHP 8.1.7 strtotime bug

Oliver Klee CR +2 V +2 Easy +1 −1 updated 06/10/22, 18:17

Commit message

PHP 8.1.7 introduced a bug that it considers the month number 100
to be valid, which breaks one of our tests.

As it is not relevant for the test whether the invalid month is
exactly 100 or 99, we now are using a number that does not trigger
the PHP bug.

https://github.com/php/php-src/issues/8749

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Oliver Klee uploaded patch set 1 06/10/22, 17:54

  2. Oliver Klee updated the commit message in patch set 2 06/10/22, 17:55

  3. core-ci voted on patch set 1 V +1 06/10/22, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27940

  4. core-ci voted on patch set 2 V +1 06/10/22, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27941

  5. Stefan Bürk updated the commit message in patch set 3 06/10/22, 18:04

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 06/10/22, 18:05

  7. Christian Kuhn commented on patch set 3 06/10/22, 18:06

    special thanks for immediate action and also creating the php issue!
  8. crell voted on patch set 3 CR +1 06/10/22, 18:06

  9. Oliver Klee updated the commit message in patch set 4 06/10/22, 18:07

  10. Oliver Klee updated the commit message in patch set 5 06/10/22, 18:07

  11. Oliver Klee commented on patch set 5 06/10/22, 18:08

    Sorry for the language mess in the commit message - I hope that it's proper English now!
  12. Christian Kuhn voted on patch set 5 V +1 CR +1 06/10/22, 18:10

  13. core-ci voted on patch set 5 V +1 06/10/22, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27944

  14. Stefan Bürk voted on patch set 5 V +2 CR +2 06/10/22, 18:17

  15. Stefan Bürk merged patch set 6 06/10/22, 18:17