Review main Merged

74872[TASK] Fix indenting for .html files

Sybille Peters CR +2 V +2 Normal +34 −35 updated 06/19/22, 01:23

Commit message

In .editorconfig indenting of 4 spaces
is configured (implicitly) for HTML
files. Most files already use this,
but some files contain TABs.

This patch converts the existing TABs
to 4 spaces.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +2
    • Chris Müller +1
    • Oliver Klee +1
    • André Buchmann +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +2
    • Chris Müller +1
    • Oliver Klee +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1216

  1. Sybille Peters uploaded patch set 1 06/11/22, 09:38

  2. Sybille Peters updated the commit message in patch set 2 06/11/22, 09:39

  3. Sybille Peters updated the commit message in patch set 3 06/11/22, 09:39

  4. core-ci voted on patch set 2 V -1 06/11/22, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27968

  5. core-ci voted on patch set 3 V -1 06/11/22, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27969

  6. core-ci voted on patch set 1 V -1 06/11/22, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27967

  7. Oliver Klee commented on patch set 3 06/11/22, 10:53

    preview.html:5

    I'm not sure we should modify this file as it's basically third-party code, and it seems to be the generated (which is why the build is failing).
  8. Sybille Peters uploaded patch set 4 06/11/22, 13:01

  9. Sybille Peters commented on patch set 3 06/11/22, 13:01

    preview.html:5 Reply

    Ah yes, makes sense, absolutely. I overlooked that. Fixed.
  10. core-ci voted on patch set 4 V +1 06/11/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27977

  11. Oliver Klee voted on patch set 4 V +1 CR +1 06/11/22, 13:10

  12. Chris Müller voted on patch set 4 V +1 CR +1 06/11/22, 15:54

  13. André Buchmann voted on patch set 4 V +1 CR +1 06/11/22, 19:28

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 06/19/22, 01:23

  15. Stefan Bürk voted on patch set 4 V +2 CR +2 06/19/22, 01:23

  16. Stefan Bürk merged patch set 5 06/19/22, 01:23