Review main Merged

74885[BUGFIX] Avoid parameter collision in IndexedSearch

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 06/13/22, 22:46

Commit message

The action to delete an indexed item in the IndexedSearch
backend module used the "id" parameter to pass the indexed
item id to the method. The controller is based on extbase and
previously, those parameters were prefixed with the plugin
namespace. However, with #97096 the parameters in extbase
backend modules are no longer prefix by default, which therefore
lead to a collision. The "id" parameter should always represent
the currently selected page, underlying code performs access
checks on this value.

This is now resolved by using a dedicated parameter, which
is not already "reserved" by underlying functionality.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 610

  1. Oli Bartsch uploaded patch set 1 06/13/22, 19:09

  2. Oli Bartsch updated the commit message in patch set 2 06/13/22, 19:10

  3. Stefan Bürk voted on patch set 2 V +1 CR +1 06/13/22, 19:15

  4. core-ci voted on patch set 1 V +1 06/13/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28023

  5. core-ci voted on patch set 2 V -1 06/13/22, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28024

  6. core-ci commented on patch set 2 06/13/22, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28024

  7. core-ci voted on patch set 2 V +1 06/13/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28024

  8. Benni Mack voted on patch set 2 V +1 CR +1 06/13/22, 21:07

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 06/13/22, 22:46

  10. Oli Bartsch merged patch set 3 06/13/22, 22:46