Review 11.5 Merged

74898[SECURITY] Do not log stacktrace in exception handlers

Oliver Hader CR +2 V +2 Easy +5 −1 updated 06/14/22, 08:13

Commit message

When a TYPO3 exception is handled through registered exception
handlers, log writers may log sensitive information to logs,
since the full stacktrace is logged.

With this change, exception handlers that extend
AbstractExceptionHandler except DebugExceptionHandler will
by default not include the exception object any more and
thereby not log the full stacktrace.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 06/14/22, 07:12

  2. Oliver Hader commented on patch set 1 V +2 CR +2 06/14/22, 07:12

    Auto-approved
  3. Oliver Hader merged patch set 2 06/14/22, 07:12

  4. core-ci voted on patch set 1 V +1 06/14/22, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28045