Review main Abandoned

74913[WIP][FEATURE] Add new Settings schema for extconf

crell CR 0 V 0 Nightmare +2650 −24 updated 02/04/23, 11:20

Commit message

This is a still-in-progress update of the Settings API.

This patch tries to integrate the new Settings.yaml file
and schema processing into the existing extconf pipeline,
so that it gets used for schema information in place of
ext_conf_template.txt if possible.  The data storage
and read/write is unaffected.

At this time, gentle feedback is welcome.

There is one workaround in AuthenticationStyleInformation.
The new Settings system, deliberately, does not have
missing values. Everything has a default value. However,
the existing login form logic shows a default button
color with a hover effect if no color is set, and a
custom color with no hover effect if a color is set.
That is enforced by an acceptance test. For the moment
the code hard-codes the default as a magic value to
not override the default behavior, to allow the test to
pass.  This is likely not the best long term solution,
but sufficient for now until we decide on a better
answer.

More of the Settings API is included than is currently
used. Further updates will make more use of them, once we
determine what the first round of changes will look like.

Review

  • Code review CR 0
  • Verified V 0

Files 67

Show 47 more files

Review log 1118

  1. crell uploaded patch set 1 06/14/22, 22:32

  2. core-ci voted on patch set 1 V -1 06/14/22, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28083

  3. Simon Schaufelberger commented on patch set 1 06/15/22, 00:01

    Settings.yaml:1 Unresolved

    This reminds me very much about Neos NodeTypes configuration. I guess it would make sense to have a look at what they are doing and get inspired for example the order property is not maintainable and instead (like the middlewares) identifiers should be used with before and after.

    SettingsPass.php:20

    no alphabetical order

    DefaultValueNotValid.php:20

    should be removed.

    RawYamlFilePass.php:21

    if you import the namespaces with Alt + Enter or with the context menu, they will be sorted automatically but S comes before T ;)

    FloatType.php:47

    please use === null instead of calling a function

    Services.yaml:376

    please only touch lines which make sense. This change doesn't make sense.
  4. Simon Schaufelberger wrote 06/15/22, 00:01

    Removed cc Simon Schaufelberger.
  5. crell commented on patch set 1 06/22/22, 17:40

    SettingsPass.php:20 Reply

    Ack

    DefaultValueNotValid.php:20 Reply

    Ack

    RawYamlFilePass.php:21 Reply

    I typically do. I'm not sure why they're in wonky orders in this patch. :-)

    FloatType.php:47 Reply

    Ack

    Services.yaml:376 Reply

    Leftover from earlier edits that added more services down here. Hence WIP. :-)
  6. crell uploaded patch set 2 06/22/22, 23:21

  7. core-ci voted on patch set 2 V -1 06/22/22, 23:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28341

  8. crell uploaded patch set 3 06/23/22, 17:05

  9. core-ci voted on patch set 3 V -1 06/23/22, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28358

  10. crell uploaded patch set 4 06/23/22, 18:04

  11. core-ci voted on patch set 4 V -1 06/23/22, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28361

  12. crell uploaded patch set 5 06/23/22, 19:20

  13. core-ci voted on patch set 5 V -1 06/23/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28365

  14. core-ci commented on patch set 5 06/23/22, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28365

  15. crell uploaded patch set 6 06/23/22, 21:22

  16. core-ci voted on patch set 6 V +1 06/23/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28373

  17. Christian Kuhn commented on patch set 6 02/04/23, 11:20

    Hey. It looks as if this approach won't make it as such for the time being. I hope it's fine to abandon here.
  18. Christian Kuhn abandoned the change 02/04/23, 11:20