74913[WIP][FEATURE] Add new Settings schema for extconf
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 67
- typo3/sysext/backend/Classes/View/AuthenticationStyleInformation.php+2 −1
- typo3/sysext/backend/Configuration/Settings.yaml1new+71 −0
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+49 −16
- typo3/sysext/core/Classes/DependencyInjection/SettingsPass.php2new+48 −0
- typo3/sysext/core/Classes/Settings/Attributes/Setting.phpnew+14 −0
- typo3/sysext/core/Classes/Settings/SchemaType/BoolType.phpnew+42 −0
- typo3/sysext/core/Classes/Settings/SchemaType/ColorType.phpnew+38 −0
- typo3/sysext/core/Classes/Settings/SchemaType/EmailType.phpnew+42 −0
- typo3/sysext/core/Classes/Settings/SchemaType/FloatType.php2new+68 −0
- typo3/sysext/core/Classes/Settings/SchemaType/IntType.phpnew+68 −0
- typo3/sysext/core/Classes/Settings/SchemaType/MultiListType.phpnew+45 −0
- typo3/sysext/core/Classes/Settings/SchemaType/PositiveIntType.phpnew+32 −0
- typo3/sysext/core/Classes/Settings/SchemaType/SchemaType.phpnew+32 −0
- typo3/sysext/core/Classes/Settings/SchemaType/SequenceType.phpnew+42 −0
- typo3/sysext/core/Classes/Settings/SchemaType/StringType.phpnew+68 −0
- typo3/sysext/core/Classes/Settings/Validator/AllowedValues.phpnew+38 −0
- typo3/sysext/core/Classes/Settings/Validator/EmailValidator.phpnew+34 −0
- typo3/sysext/core/Classes/Settings/Validator/EvenOdd.phpnew+46 −0
- typo3/sysext/core/Classes/Settings/Validator/IncorrectType.phpnew+27 −0
- typo3/sysext/core/Classes/Settings/Validator/ListTypeValidator.phpnew+40 −0
Show 47 more files
- typo3/sysext/core/Classes/Settings/Validator/MaxValueValidator.phpnew+34 −0
- typo3/sysext/core/Classes/Settings/Validator/MinValueValidator.phpnew+34 −0
- typo3/sysext/core/Classes/Settings/Validator/NotANumber.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Validator/RegexValidationFailed.phpnew+26 −0
- typo3/sysext/core/Classes/Settings/Validator/RegexValidator.phpnew+34 −0
- typo3/sysext/core/Classes/Settings/Validator/TooBig.phpnew+27 −0
- typo3/sysext/core/Classes/Settings/Validator/TooSmall.phpnew+27 −0
- typo3/sysext/core/Classes/Settings/Validator/TypeValidator.phpnew+37 −0
- typo3/sysext/core/Classes/Settings/Validator/ValidationError.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Validator/ValidationErrors.phpnew+40 −0
- typo3/sysext/core/Classes/Settings/Validator/Validator.phpnew+28 −0
- typo3/sysext/core/Classes/Settings/Widgets/CheckboxesField.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Widgets/CheckboxField.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Widgets/CsvField.phpnew+25 −0
- typo3/sysext/core/Classes/Settings/Widgets/MultivalueTextField.phpnew+25 −0
- typo3/sysext/core/Classes/Settings/Widgets/NumberField.phpnew+25 −0
- typo3/sysext/core/Classes/Settings/Widgets/RadioButtonsField.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Widgets/SelectField.phpnew+29 −0
- typo3/sysext/core/Classes/Settings/Widgets/TextAreaField.phpnew+22 −0
- typo3/sysext/core/Classes/Settings/Widgets/TextField.phpnew+25 −0
- typo3/sysext/core/Classes/Settings/Widgets/Widget.phpnew+29 −0
- typo3/sysext/core/Classes/Settings/CategoryDefinition.phpnew+29 −0
- typo3/sysext/core/Classes/Settings/ConstructorHydratable.phpnew+36 −0
- typo3/sysext/core/Classes/Settings/DefaultValueNotValid.php2new+37 −0
- typo3/sysext/core/Classes/Settings/FormField.phpnew+31 −0
- typo3/sysext/core/Classes/Settings/Hydratable.phpnew+39 −0
- typo3/sysext/core/Classes/Settings/RawYamlFilePass.php2new+111 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.phpnew+59 −0
- typo3/sysext/core/Classes/Settings/SettingNotFound.phpnew+37 −0
- typo3/sysext/core/Classes/Settings/Settings.phpnew+154 −0
- typo3/sysext/core/Classes/Settings/SettingsExtConfBridge.phpnew+104 −0
- typo3/sysext/core/Classes/Settings/SettingsSchema.phpnew+101 −0
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+1 −1
- typo3/sysext/core/Configuration/Services.php+3 −0
- typo3/sysext/core/Configuration/Services.yaml2+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_txt_only/ext_conf_template.txtnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_txt_only/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_yaml_only/Configuration/Settings.yamlnew+23 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_yaml_only/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_yaml_txt/Configuration/Settings.yamlnew+23 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_yaml_txt/ext_conf_template.txtnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_settings_yaml_txt/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Settings/SettingsTest.phpnew+76 −0
- typo3/sysext/core/Tests/Unit/Settings/SettingsExtConfBridgeTest.phpnew+100 −0
- typo3/sysext/felogin/Configuration/Settings.yaml-disablenew+165 −0
- typo3/sysext/install/Classes/Controller/SettingsController.php+4 −1
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.php+18 −5
Review log 1118
-
crell uploaded patch set 1 06/14/22, 22:32
-
core-ci voted on patch set 1 V -1 06/14/22, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28083
-
Simon Schaufelberger commented on patch set 1 06/15/22, 00:01
SettingsPass.php:20no alphabetical orderDefaultValueNotValid.php:20should be removed.RawYamlFilePass.php:21if you import the namespaces with Alt + Enter or with the context menu, they will be sorted automatically but S comes before T ;)FloatType.php:47please use === null instead of calling a functionServices.yaml:376please only touch lines which make sense. This change doesn't make sense. -
Simon Schaufelberger wrote 06/15/22, 00:01
Removed cc Simon Schaufelberger. -
crell commented on patch set 1 06/22/22, 17:40
SettingsPass.php:20ReplyAckDefaultValueNotValid.php:20ReplyAckRawYamlFilePass.php:21ReplyI typically do. I'm not sure why they're in wonky orders in this patch. :-)FloatType.php:47ReplyAckServices.yaml:376ReplyLeftover from earlier edits that added more services down here. Hence WIP. :-) -
crell uploaded patch set 2 06/22/22, 23:21
-
core-ci voted on patch set 2 V -1 06/22/22, 23:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28341
-
crell uploaded patch set 3 06/23/22, 17:05
-
core-ci voted on patch set 3 V -1 06/23/22, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28358
-
crell uploaded patch set 4 06/23/22, 18:04
-
core-ci voted on patch set 4 V -1 06/23/22, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28361
-
crell uploaded patch set 5 06/23/22, 19:20
-
core-ci voted on patch set 5 V -1 06/23/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28365
-
core-ci commented on patch set 5 06/23/22, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28365
-
crell uploaded patch set 6 06/23/22, 21:22
-
core-ci voted on patch set 6 V +1 06/23/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28373
-
Christian Kuhn commented on patch set 6 02/04/23, 11:20
Hey. It looks as if this approach won't make it as such for the time being. I hope it's fine to abandon here. -
Christian Kuhn abandoned the change 02/04/23, 11:20
Settings.yaml:1Unresolved