74923[BUGFIX] Streamline `isSystemMaintainer()` checks
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php5+9 −9
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+99 −0
- typo3/sysext/install/Configuration/Backend/Modules.php+1 −1
Review log 1624
-
Andreas Kienast uploaded patch set 1 06/17/22, 06:55
-
Andreas Kienast uploaded patch set 2 06/17/22, 06:59
-
core-ci voted on patch set 1 V -1 06/17/22, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28121
-
core-ci voted on patch set 2 V -1 06/17/22, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28122
-
Andreas Kienast uploaded patch set 3 06/17/22, 07:41
-
core-ci voted on patch set 3 V -1 06/17/22, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28125
-
Andreas Kienast uploaded patch set 4 06/17/22, 07:58
-
core-ci voted on patch set 4 V -1 06/17/22, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28126
-
Andreas Kienast uploaded patch set 5 06/17/22, 08:37
-
core-ci voted on patch set 5 V +1 06/17/22, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28130
-
Andreas Kienast uploaded patch set 6 06/17/22, 12:34
-
core-ci voted on patch set 6 V +1 06/17/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28142
-
Andreas Kienast updated the commit message in patch set 7 06/17/22, 13:18
-
core-ci voted on patch set 7 V +1 06/17/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28149
-
Nikita Hovratov uploaded patch set 8 06/17/22, 19:19
-
core-ci voted on patch set 8 V +1 06/17/22, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28163
-
Andreas Kienast commented on patch set 8 06/17/22, 19:35
-
Nikita Hovratov commented on patch set 8 06/17/22, 20:16
BackendUserAuthentication.php:454ReplyLearned it by reading Larrys patches. Needs to be changed back of course for v11. -
Nikita Hovratov commented on patch set 8 V -1 06/17/22, 20:48
BackendUserAuthentication.php:448This empty string for unsetting system maintainers smells fishy and was nowhere documented outside of this comment. And on top of that not implemented as stated. Why would you want to prevent accessing the install tool modules altogether anyway I wonder. Also I get "array_map(): Argument #2 ($array) must be of type array, string given" when setting an empty string and then calling /typo3/install.php in SessionService.php line 273 Is the problem only the MfaProvider tests, which need system maintainers to be disabled? Maybe we could come up there with another solution? -
Andreas Kienast commented on patch set 8 06/17/22, 20:58
BackendUserAuthentication.php:448ReplyI also wondered about the empty string thing, but it's there since quite some time. The MfaProvider tests needs adoption because phpunit sends some headers which will cause issues once ->logoff() is called, this creates a new instance of SessionService, which will then throw errors as headers are already sent. -
Stefan Bürk commented on patch set 8 07/08/22, 21:13
BackendUserAuthentication.php:448Reply UnresolvedI think we should ensure that SessionService only send "headers()" in real web requests (not cli/test). They are not checkable anyway. -
Benni Mack commented on patch set 8 04/14/23, 16:58
Ping - how to proceed here? -
Andreas Kienast commented on patch set 8 04/21/23, 11:26
Reply
I'll abandon this for now -
Andreas Kienast abandoned the change 04/21/23, 11:26
BackendUserAuthentication.php:454