Review main Merged

74928[BUGFIX] Toggle inline controls only in own scope

Nikita Hovratov CR +2 V +2 Easy +12 −6 updated 08/12/22, 22:06

Commit message

The former approach in #91808 to fix scoped toggling didn't
work with levelLinksPosition "bottom", as the querySelector
could find another control container inside another child
inline field first.

Another solution, which is now possible, works with the
":scope" selector. Only nodes with a direct parent will be
found this way.

In addition, a new helper class is added for the top control
container, as it is wrapped in another div. This enables
toggling of both buttons, in case levelLinksPosition "both"
is set.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 79

  1. Nikita Hovratov uploaded patch set 1 06/17/22, 18:52

  2. core-ci voted on patch set 1 V +1 06/17/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28161

  3. Lina Wolf commented on patch set 1 07/05/22, 15:30

    Unable to reproduce the original bug reportet. Using EXT:styleguide with table tx_styleguide_inline_1n1n.php with TCA settings 'inline_1' => [ 'exclude' => 1, 'label' => 'inline_1', 'config' => [ 'type' => 'inline', 'foreign_table' => 'tx_styleguide_inline_1n1n_child', 'foreign_field' => 'parentid', 'foreign_table_field' => 'parenttable', 'minitems' => 1, 'maxitems' => 1, 'levelLinksPosition' => 'bottom', ], ], works fine and hides the correct button. How to reproduce?
  4. Nikita Hovratov uploaded patch set 2 07/27/22, 14:50

  5. core-ci voted on patch set 2 V +1 07/27/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29619

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 08/12/22, 22:03

    covered in styleguide inline_1n inline_2 (main branch) now.
  7. Stefan Bürk voted on patch set 2 V +1 CR +1 08/12/22, 22:03

  8. Nikita Hovratov voted on patch set 2 V +2 CR +2 08/12/22, 22:05

  9. Nikita Hovratov merged patch set 3 08/12/22, 22:06