74928[BUGFIX] Toggle inline controls only in own scope
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
- Bug #97786Wrong button hidden in nested inline relations
- Bug #91808Nested IRRE with maxitems hides last inline control button / toggles inline control buttons wrong
- Bug #92382levelLinksPosition=bottom is not working correctly especially with minitems=1 set and leads to misbehaviour in inline children
Files 3
Review log 79
-
Nikita Hovratov uploaded patch set 1 06/17/22, 18:52
-
core-ci voted on patch set 1 V +1 06/17/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28161
-
Lina Wolf commented on patch set 1 07/05/22, 15:30
Unable to reproduce the original bug reportet. Using EXT:styleguide with table tx_styleguide_inline_1n1n.php with TCA settings 'inline_1' => [ 'exclude' => 1, 'label' => 'inline_1', 'config' => [ 'type' => 'inline', 'foreign_table' => 'tx_styleguide_inline_1n1n_child', 'foreign_field' => 'parentid', 'foreign_table_field' => 'parenttable', 'minitems' => 1, 'maxitems' => 1, 'levelLinksPosition' => 'bottom', ], ], works fine and hides the correct button. How to reproduce? -
Nikita Hovratov uploaded patch set 2 07/27/22, 14:50
-
core-ci voted on patch set 2 V +1 07/27/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29619
-
Christian Kuhn commented on patch set 2 V +1 CR +1 08/12/22, 22:03
covered in styleguide inline_1n inline_2 (main branch) now. -
Stefan Bürk voted on patch set 2 V +1 CR +1 08/12/22, 22:03
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 08/12/22, 22:05
-
Nikita Hovratov merged patch set 3 08/12/22, 22:06