Review 11.5 Merged

74960[BUGFIX] Allow XCLASSing of WorkspaceRecord

Christian Kuhn CR +2 V +2 Normal +101 −8 updated 06/19/22, 00:51

Commit message

The factory method WorkspaceRecord::get() now uses a proper
makeInstance() call instead of new for creating new instances,
which allows XCLASSing the class and aligns object creation
to "the TYPO3 way" in that place.

Also add a regression test.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/19/22, 00:38

  2. core-ci voted on patch set 1 V +1 06/19/22, 00:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28209

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/19/22, 00:51

  4. Stefan Bürk merged patch set 2 06/19/22, 00:51