Review main Merged

74963[TASK] Allow global event handlers on click

Christian Kuhn CR +2 V +2 Normal +68 −10 updated 06/19/22, 21:51

Commit message

The backend related global-event-handler is a helper
to especially submit POST forms on various DOM elements.
It supersedes "onClick" events by having a watcher defined
by data attributes.
The patch extends given solution to also act on other
elements, especially the "<a .." tag.
This will be used by the upcoming backend TypoScript
Object browser and in general allows to send POST
requests instead of GET requests on many elements.
The JavaScript implementation has been prepared a while
ago already, but missed a use-case up until now.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 06/19/22, 21:35

  2. core-ci voted on patch set 1 V -1 06/19/22, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28226

  3. core-ci voted on patch set 1 V +1 06/19/22, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28226

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 06/19/22, 21:49

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 06/19/22, 21:51

  6. Stefan Bürk merged patch set 2 06/19/22, 21:51