Review main Merged

74966[FEATURE] Set content language direction in RichText elements

Georg Ringer CR +2 V +2 Easy +49 −0 updated 09/06/22, 18:14

Commit message

Set the content language of RichText elements based on the direction
of the site language of the given element.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1418

  1. Georg Ringer uploaded patch set 1 06/20/22, 13:40

  2. Georg Ringer commented on patch set 1 V +1 CR +1 06/20/22, 13:40

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/20/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28267

  4. Philipp Kitzberger commented on patch set 1 V +1 CR +1 06/20/22, 15:09

    Cool, that way the bidi plugin actually works as well when trying to embed a paragraph of english language into a RTL text.
  5. Georg Ringer uploaded patch set 2 06/21/22, 04:49

  6. core-ci voted on patch set 2 V +1 06/21/22, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28286

  7. Guido Schmechel voted on patch set 2 V +1 CR +1 07/08/22, 23:15

  8. Riccardo De Contardi voted on patch set 2 V +1 07/09/22, 14:56

  9. Andreas Kienast commented on patch set 2 V -1 07/09/22, 15:30

    I guess something is missing. I set the text direction to "rtl" in my default language, but `contentsLangDirection` remains an empty string.
  10. Georg Ringer uploaded patch set 3 07/21/22, 19:12

  11. core-ci voted on patch set 3 V +1 07/21/22, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29406

  12. Andreas Kienast uploaded patch set 4 07/22/22, 09:53

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 07/22/22, 09:53

  14. core-ci voted on patch set 4 V +1 07/22/22, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29417

  15. Guido Schmechel voted on patch set 4 V +1 CR +1 07/22/22, 10:33

  16. Oliver Hader voted on patch set 4 CR +1 07/23/22, 09:09

  17. Georg Ringer voted on patch set 4 V +2 CR +2 09/06/22, 18:14

  18. Georg Ringer merged patch set 5 09/06/22, 18:14