74967[TASK] Add exception message to log message
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Jörg Bösche +1
- Felix P. +1
- Stefan Froemken +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Felix P. +1
- Stefan Froemken +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Georg Ringer uploaded patch set 1 06/21/22, 05:04
-
Georg Ringer commented on patch set 1 06/21/22, 05:04
This change is ready for review. -
core-ci voted on patch set 1 V -1 06/21/22, 05:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28287
-
core-ci voted on patch set 1 V +1 06/21/22, 05:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28287
-
Simon Schaufelberger voted on patch set 1 V +1 CR +1 06/21/22, 07:42
-
Jörg Bösche voted on patch set 1 CR +1 06/23/22, 13:42
-
Oliver Klee voted on patch set 1 CR +1 06/23/22, 13:59
-
Felix P. voted on patch set 1 V +1 CR +1 06/24/22, 14:14
-
Stefan Froemken voted on patch set 1 V +1 CR +1 08/05/22, 20:21
-
Christian Kuhn commented on patch set 1 V +1 CR +1 08/12/22, 20:56
the real issue is here that \RuntimeException shouldn't be caught at all, but should bubble up to core exception handler. however, fal has a bad history of throwing 'global' exception that are expected to be caught by upper level code, and this is nothing we can change in a bugfix. as such, that change is ok for now, but 'catch \Exception' or a direct inheritance of that is bad practice and the last usages of that should vanish. -
Stefan Bürk voted on patch set 1 V +2 CR +2 08/12/22, 20:57
-
Stefan Bürk merged patch set 2 08/12/22, 20:57