Review main Merged

74970[BUGFIX] Fix failing test caused by vfs removal

Anja Leichsenring CR +2 V +2 Easy +3 −2 updated 06/22/22, 07:41

Commit message

With #74882 usage of vfs was reduced in unit tests, revealing
side effects when tests relied on each other to create
files or folders. Now they need to take care on their own
and clean up behind.
This is one of the missed cases where a test still relied on
a test directory being created.

The test now creates and removes the required assets themself.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Anja Leichsenring uploaded patch set 1 06/22/22, 06:05

  2. core-ci voted on patch set 1 V +1 06/22/22, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28314

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 06/22/22, 07:10

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 06/22/22, 07:41

  5. Christian Kuhn merged patch set 2 06/22/22, 07:41