Review main Merged

74979[TASK] Drop unused scss variables

Benjamin Kott CR +2 V +2 Easy +9 −20 updated 06/24/22, 15:28

Commit message

The following variables are not used or do not differ from their equivalents in bootstrap 5.x:

$font-size-h1
$font-size-h2
$font-size-h3
$font-size-h4
$border-radius-base
$border-radius-large
$border-radius-small

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 79

  1. Benjamin Kott uploaded patch set 1 06/24/22, 08:54

  2. core-ci voted on patch set 1 V -1 06/24/22, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28379

  3. core-ci voted on patch set 1 V +1 06/24/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28379

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/24/22, 09:40

  5. Oliver Klee commented on patch set 1 06/24/22, 09:47

    Benjamin, how on earth do you spot these issues? Is this some kind of magic?
  6. Oli Bartsch voted on patch set 1 V +2 CR +2 06/24/22, 11:59

  7. Oli Bartsch merged patch set 2 06/24/22, 11:59

  8. Benjamin Kott commented on patch set 2 06/24/22, 15:04

    Reply

    Well, strg+f through the project when i find stuff in a file called legacy ;)
  9. Oliver Klee commented on patch set 2 06/24/22, 15:28

    Reply

    Ah. :-)