Review main Merged

74981[TASK] Update @typo3.icons to v3.1

Benjamin Kott CR +2 V +2 Nightmare +947 −2076 updated 07/01/22, 14:54

Commit message

With the update to v3.x of the TYPO3 Icon set, there comes
a little change in favor of understanding what sizes of
icons to use. There is no defined "default" size anymore.

While it is still usable, the new default scales with font size.
So it does not matter if you call it "default" or "auto".

The default size for icon rendering was adapted to now use
the "medium" size. That is the same size as default was before.

Fixed sizes are now defined in order:
small:  16px
medium: 32px
large:  64px

Aside from some special treatment the CSS from the icon set
is now used. It was already reworked in the icon set to make
use of CSS variables instead of compiled fixed compiled values.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 771

Show 751 more files

Review log 2535

Show 710 earlier messages
  1. Benjamin Kott uploaded patch set 1 06/24/22, 10:49

  2. core-ci voted on patch set 1 V -1 06/24/22, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28383

  3. Georg Ringer commented on patch set 1 06/24/22, 11:19

    This change is ready for review.
    can we backport just the new icons to v11 as well?
  4. Benjamin Kott marked it work in progress 06/24/22, 11:31

  5. Benjamin Kott commented on patch set 1 06/24/22, 11:31

    This change is ready for review.

    Reply

    the patch is NOT ready for review, this is why it was marked WIP
  6. Benjamin Kott uploaded patch set 2 06/24/22, 11:58

  7. core-ci voted on patch set 2 V -1 06/24/22, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28387

  8. Benjamin Kott uploaded patch set 3 06/24/22, 14:12

  9. Benjamin Kott uploaded patch set 4 06/24/22, 14:17

  10. core-ci voted on patch set 3 V -1 06/24/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28394

  1. core-ci voted on patch set 4 V -1 06/24/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28395

  2. Benjamin Kott uploaded patch set 5 06/24/22, 14:28

  3. core-ci voted on patch set 5 V +1 06/24/22, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28396

  4. Benjamin Kott updated the commit message in patch set 6 06/24/22, 15:02

  5. Benjamin Kott commented on patch set 6 06/24/22, 15:03

    This change is ready for review.
  6. core-ci voted on patch set 6 V +1 06/24/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28398

  7. Simon Schaufelberger commented on patch set 6 CR -1 06/25/22, 00:49

    Dimension.php:49

    this changes default from medium to small. I guess this is not intended as this would be a breaking change
  8. Benjamin Kott commented on patch set 6 06/25/22, 06:39

    Dimension.php:49 Reply

    intended change, since behaviour changed in icon set. default ist just a fallback to auto scaling now, as described in the commit message. since there is no way to describe it as 1em, it falls back to 16px in this case. everyone that does directly request the default size will now get icons that are adapting to the font size. everyone that does not provide the size attribute at all, will get the medium size now that results in unchanged behaviour. as described in the commit message -> "default" changed from fixed to adaptive -> "medium" now fills the place of previous "default" with 32px fixed size -> icon API adapted to use "medium" insead of "default" as internal default to ensure unchanged behaviour, aside from really explicit calls. i do not consider this breaking. the edge edge edge case where you have called SIZE_DEFAULT now only has an adaptive icon instead of a fixed size.
  9. Simon Schaufelberger commented on patch set 6 CR +1 06/25/22, 07:53

    Dimension.php:49 Reply

    Ah ok, that is much easier to understand
  10. Oliver Hader uploaded patch set 7 06/28/22, 08:17

  11. Oliver Hader commented on patch set 7 V +1 06/28/22, 08:18

    Looks good to me. I still think we should have at least an "Important.RST" file, so just that people know about that change..
  12. core-ci voted on patch set 7 V +1 06/28/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28453

  13. Benjamin Kott uploaded patch set 8 07/01/22, 12:44

  14. core-ci voted on patch set 8 V -1 07/01/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28567

  15. core-ci voted on patch set 8 V +1 07/01/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28567

  16. Oliver Hader voted on patch set 8 V +1 CR +1 07/01/22, 14:00

  17. Andreas Kienast commented on patch set 8 CR -1 07/01/22, 14:03

    on it
  18. Andreas Kienast uploaded patch set 9 07/01/22, 14:10

  19. Andreas Kienast voted on patch set 9 V +1 CR +1 07/01/22, 14:11

  20. Oliver Hader voted on patch set 9 V +1 CR +1 07/01/22, 14:15

  21. Oliver Hader voted on patch set 9 V +2 CR +2 07/01/22, 14:16

  22. Andreas Kienast voted on patch set 9 V +2 CR +2 07/01/22, 14:16

  23. core-ci voted on patch set 9 V +1 07/01/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28579

  24. Andreas Kienast merged patch set 10 07/01/22, 14:20

  25. Andreas Kienast commented on patch set 10 07/01/22, 14:54

    Meh, the text in the backend login button is now aligned to left.