Review main Merged

74983[TASK] Allow xdebug with PHP8.2 in Build/Scripts/runTests.sh

Stefan Bürk CR +2 V +2 Easy +0 −6 updated 07/01/22, 08:07

Commit message

xdebug does not have an official compatible version which can
be used with PHP8.2, and thus xdebug had been missing in the
PHP8.2 alpha1 image. To avoid using xdebug with PHP8.2 this
had been guarded with a corresponding check in `runTests.sh`.

`typo3/core-testing-php82` docker image has since been rebuilt
with PHP8.2 alpha2 and using a fork of xdebug, which compiles
the extension against PHP8.2.

The check in `runTests.sh` is now removed again in order to
allow early xdebug-ging using `Build/Scripts/runTests.sh`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sybille Peters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Stefan Bürk uploaded patch set 1 06/24/22, 13:59

  2. core-ci voted on patch set 1 V +1 06/24/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28391

  3. Simon Schaufelberger updated the commit message in patch set 2 06/25/22, 00:36

  4. core-ci voted on patch set 2 V +1 06/25/22, 00:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28404

  5. Sybille Peters updated the commit message in patch set 3 06/29/22, 21:20

  6. Sybille Peters voted on patch set 3 V +1 CR +1 06/29/22, 21:22

  7. core-ci voted on patch set 3 V +1 06/29/22, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28513

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 07/01/22, 08:07

  9. Christian Kuhn merged patch set 4 07/01/22, 08:07