74985[TASK] Improve the comments and type annotations of MailUtility
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1113
-
Oliver Klee uploaded patch set 1 06/25/22, 21:26
-
Oliver Klee commented on patch set 1 06/25/22, 21:26
Note: As the type annotations had already been fixed on main, I was able to copy the comments from main. This also is the reason why this is 11.5-only. -
core-ci voted on patch set 1 V +1 06/25/22, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28417
-
Nikita Hovratov commented on patch set 1 06/25/22, 22:04
Reply
Is this a (partial) backport? If yes, which commit? -
Oliver Klee commented on patch set 1 06/26/22, 09:43
Reply
Yes, from this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74290 (That is commit 7b4d1cd58ce19a729b689b8ae4dc8f9a4ec34d8e.) -
Oliver Klee commented on patch set 1 06/26/22, 10:07
How to verify: As there are no changes to executable code, checking that PHPStan is happy should suffice. -
Nikita Hovratov voted on patch set 1 V +1 CR +1 06/26/22, 16:07
-
Oliver Klee commented on patch set 1 06/27/22, 10:29
Nikita, thanks for adding the relation in the ticket! -
Stefan Bürk updated the commit message in patch set 2 06/27/22, 10:37
-
Stefan Bürk voted on patch set 2 V +1 CR +1 06/27/22, 10:37
-
core-ci voted on patch set 2 V +1 06/27/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28432
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 06/27/22, 10:48
-
Nikita Hovratov merged patch set 3 06/27/22, 10:48