74987[!!!][FEATURE] New TypoScript parser
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
Files 165
- typo3/sysext/core/Classes/TypoScript/AST/CurrentObjectPath/CurrentObjectPath.phpnew+73 −0
- typo3/sysext/core/Classes/TypoScript/AST/CurrentObjectPath/CurrentObjectPathStack.php4new+63 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractChildNode.php2new+88 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.phpnew+148 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/ChildNode.phpnew+25 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/ChildNodeInterface.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.phpnew+107 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/ReferenceChildNode.phpnew+51 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.phpnew+96 −0
- typo3/sysext/core/Classes/TypoScript/AST/Traverser/AstTraverser.phpnew+73 −0
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstSortChildrenVisitor.phpnew+43 −0
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstVisitorInterface.phpnew+36 −0
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.phpnew+321 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractConditionInclude.phpnew+83 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php2new+180 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AtImportInclude.phpnew+29 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionElseInclude.phpnew+39 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionInclude.phpnew+31 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTyposcriptInclude.phpnew+30 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/DefaultTypoScriptInclude.phpnew+28 −0
Show 145 more files
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/DefaultTypoScriptMagicKeyInclude.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ExtensionStaticInclude.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/FileInclude.phpnew+30 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeConditionInterface.phpnew+58 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.phpnew+117 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeStaticFileDatabaseInclude.phpnew+29 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeStaticFileFileInclude.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeTyposcriptInclude.phpnew+27 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/RootInclude.php4new+40 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SegmentInclude.phpnew+34 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SiteInclude.phpnew+27 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/SysTemplateInclude.phpnew+31 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/ConditionVerdictAwareIncludeTreeTraverser.phpnew+78 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/IncludeTreeTraverser.phpnew+66 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/IncludeTreeTraverserInterface.phpnew+37 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeAstBuilderVisitor.phpnew+80 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.phpnew+57 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSetupConditionConstantSubstitutionVisitor.phpnew+90 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeVisitorInterface.phpnew+40 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeBuilder.phpnew+775 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.phpnew+506 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/AbstractLine.phpnew+41 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/BlockCloseLine.phpnew+27 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/CommentLine.phpnew+31 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionElseLine.phpnew+27 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionLine.phpnew+45 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ConditionStopLine.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/EmptyLine.phpnew+34 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierAssignmentLine.phpnew+68 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierBlockOpenLine.phpnew+47 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierCopyLine.phpnew+68 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierFunctionLine.phpnew+80 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierReferenceLine.phpnew+66 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/IdentifierUnsetLine.phpnew+47 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ImportLine.phpnew+49 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ImportOldLine.phpnew+48 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/InvalidLine.phpnew+35 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineInterface.phpnew+42 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineStream.phpnew+78 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/AbstractToken.phpnew+79 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/AbstractTokenStream.php2new+113 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/ConstantAwareTokenStream.phpnew+61 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/IdentifierToken.phpnew+39 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/IdentifierTokenStream.phpnew+105 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/Token.phpnew+31 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenInterface.phpnew+68 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenStream.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenStreamInterface.phpnew+77 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenType.phpnew+72 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LosslessTokenizer.phpnew+914 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LossyTokenizer.phpnew+597 −0
- typo3/sysext/core/Classes/TypoScript/Tokenizer/TokenizerInterface.phpnew+42 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+5 −0
- typo3/sysext/core/Configuration/Services.yaml+20 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97816-TypoScriptSyntaxChanges.rstnew+139 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97816-TypoScriptSyntaxImprovements.rst6new+173 −0
- typo3/sysext/core/Documentation/Settings.cfg+1 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/SubDirectory/SubDirectory.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/SubDirectory2/SubDirectory2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/setup.noOkEndingnew+2 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/setup2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario1/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario2/pathTraversal1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/AbsoluteImport/Scenario2/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/InvalidImport/invalidPathTraversalTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/InvalidImport/pathTraversal1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/InvalidImport/pathTraversal2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/InvalidImport/pathTraversal3.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/InvalidImport/pathTraversal4.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/RelativeRecursiveDirectory/relativeRecursive.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/RelativeRecursiveDirectory/relativeTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/RelativeSubDirectory/relativeTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/hasRelative1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/hasRelative2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/hasRelative3.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/hasRelative4.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/hasRelative5.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/RelativeImport/relativeTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/AtImport/invalidPathTraversalTarget.typoscriptnew+2 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario1/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/RelativeSub/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative3.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario3/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario3/setup2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir1/auto1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir1/auto2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir2/auto1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup2.foo.txtnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup3.typo3new+2 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario1/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/RelativeSub/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative3.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/subInclude.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario3/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario3/setup2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir1/auto1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir1/auto2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir2/auto1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup2.foo.txtnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup3.typo3new+2 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario1/invalidPathTraversalTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario1/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario2/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario3/invalidPathTraversalTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario3/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario4/setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/invalidPathTraversalTarget.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/basedOnAfterIncludeStatic.csv2new+8 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/basedOnBeforeIncludeStatic.csv2new+8 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/basedOnSimple.csv3new+8 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/constants.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/singleRootTemplate.csv2new+6 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/twoPagesTwoTemplates.csv2new+8 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/twoPagesTwoTemplatesBothClear.csv2new+8 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/SysTemplate/twoTemplatesOnPage.csvnew+7 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Visitor/IncludeTreeSetupConditionConstantSubstitutionVisitorTest.phpnew+123 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeBuilderTest.phpnew+228 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.phpnew+1591 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderTest.phpnew+1897 −0
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/ConditionElseIncludeTest.phpnew+46 −0
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTest.phpnew+46 −0
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTyposcriptIncludeTest.phpnew+46 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/ConditionLineTest.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierAssignmentLineTest.phpnew+45 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierBlockOpenLineTest.phpnew+35 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierCopyLineTest.phpnew+45 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierFunctionLineTest.phpnew+57 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierReferenceLineTest.phpnew+45 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/IdentifierUnsetLineTest.phpnew+35 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/ImportLineTest.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/ImportOldLineTest.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Token/IdentifierTokenStreamTest.phpnew+64 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Token/TokenStreamTest.phpnew+76 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Token/TokenTest.phpnew+65 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/TokenizerInterfaceTest.phpnew+7201 −0
Review log 2333
Show 48 earlier messages
-
Christian Kuhn uploaded patch set 1 06/27/22, 15:22
-
core-ci voted on patch set 1 V +1 06/27/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28439
-
Christian Kuhn uploaded patch set 2 06/27/22, 17:10
-
Christian Kuhn updated the commit message in patch set 3 06/27/22, 17:17
-
core-ci voted on patch set 2 V +1 06/27/22, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28441
-
core-ci voted on patch set 3 V +1 06/27/22, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28443
-
Christian Kuhn uploaded patch set 4 06/27/22, 18:27
-
core-ci voted on patch set 4 V +1 06/27/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28444
-
Christian Kuhn uploaded patch set 5 06/28/22, 13:36
-
core-ci voted on patch set 5 V +1 06/28/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28458
-
Christian Kuhn uploaded patch set 6 06/28/22, 15:37
-
core-ci voted on patch set 6 V +1 06/28/22, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28460
-
Christian Kuhn uploaded patch set 7 06/28/22, 16:37
-
core-ci voted on patch set 7 V +1 06/28/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28463
-
Simon Schaufelberger updated the commit message in patch set 8 06/28/22, 18:28
-
core-ci voted on patch set 8 V +1 06/28/22, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28464
-
Stefan Bürk commented on patch set 8 06/28/22, 20:12
CurrentObjectPathStack.php:50Nitpick: superflous space ? Normally inc/decc are directly "attached" to the variable .. curious, not cgl rule for this.AbstractChildNode.php:58Are there not tests for it ? e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987/7/typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderTest.php#1362 or are meant the final "replacement" within ContentObjectRenderer cObjGetSingle() ?AbstractInclude.php:45Should we make this method "final" ? Extending classes can handle differences in calles `serialize()`RootInclude.php:33NoOp - what speak against throwing a exception instead if "someone" tries it (later when we directly use object structure). Or do I oversee something ?RootInclude.php:38See above for setIdentifiert()AbstractTokenStream.php:51basedOnAfterIncludeStatic.csv:62x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because both templates are on different pids and thus sorting to "relevant".basedOnBeforeIncludeStatic.csv:62x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because both templates are on different pids and thus sorting to "relevant".basedOnSimple.csv:62x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because both templates are on different pids and thus sorting to "relevant".singleRootTemplate.csv:52x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because only one template.twoPagesTwoTemplates.csv:62x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because both templates are on different pids and thus sorting to "relevant".twoPagesTwoTemplatesBothClear.csv:62x field "sorting" for sys_template ? Would bet this would fail on postgress, if test would test for a sorting on the same pid. Basicly wrong, even if not make a different for current case, because both templates are on different pids and thus sorting to "relevant". -
Markus Klein commented on patch set 8 06/29/22, 06:53
Feature-97816-TypoScriptSyntaxImprovements.rst:68While we are at it. This line and line 52 above are very confusing for a newcomer. Why does the one qualify as comment there but not here. I would strongly suggestion to deprecate in-line comments completely! -
Stefan Bürk commented on patch set 8 06/29/22, 07:01
Feature-97816-TypoScriptSyntaxImprovements.rst:68ReplyI would guess, because for "assignements" there must be e.g the ability for the field fallback handling: ``` page.10.field = nav_title // title ``` thus the reasin it is not a comment for assignment operator. That is a old double usage making line comment for assignment inpossible, but in generall possible for all other cases. -
Markus Klein commented on patch set 8 06/29/22, 08:59
Feature-97816-TypoScriptSyntaxImprovements.rst:68ReplyI know that, no worries. My comment is about *new TYPO3 users*, not knowing such nasty details. I would take the chance now and make the hard cut and even disallow comments in the same line completely. There is no point about doing this, just put it in the line above. It makes everything easier to understand. -
Simon Schaufelberger commented on patch set 8 06/29/22, 10:50
Feature-97816-TypoScriptSyntaxImprovements.rst:68Reply> It makes everything easier to understand while typoscript is line based, this makes total sense in contrast to php which you could put more or less all in one line and it still works. I also give +1 for dropping inline comments. -
Christian Kuhn commented on patch set 8 07/01/22, 09:50
CurrentObjectPathStack.php:38Replyafaik no hard rule for that and i probably even mix it within the patch. i must say that i don't care too much for this detail. if we feel lucky, we could sort out details later and then have a global core patch to fix it to whatever we agreed on? -> i'll not change here now.CurrentObjectPathStack.php:50ReplyAckAbstractChildNode.php:58ReplyDoneAbstractInclude.php:45Replygood idea.RootInclude.php:33Replyyep. done.RootInclude.php:38Replyyep. done.AbstractTokenStream.php:51ReplyDoneFeature-97816-TypoScriptSyntaxImprovements.rst:68ReplyI tend to give integrators as much comment freedom as possible. Goal of my implementation was to especially fix the nasty '*/ has to be on a single line'. It's basically like that now: place comments anywhere (and it *is* helpful to be able to place a comment at the end of a condition line or similar), but be aware that assignments terminate at end of line: comment and other special chars are never interpreted, but have the advantage those need no quoting. This looks logical to me and is rather easy to explain. We could discuss a deprecation of the comment logic after main merge again, but it feels to me as if we should rather go with more freedom as proposed instead of more restrictions.basedOnAfterIncludeStatic.csv:6ReplyDonebasedOnBeforeIncludeStatic.csv:6ReplyDonebasedOnSimple.csv:6ReplyDonebasedOnSimple.csv:6ReplyDonesingleRootTemplate.csv:5ReplyDonetwoPagesTwoTemplates.csv:6ReplyDonetwoPagesTwoTemplatesBothClear.csv:6Replythank you! hope i got them all, now. -
Christian Kuhn uploaded patch set 9 07/01/22, 09:51
-
core-ci voted on patch set 9 V -1 07/01/22, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28561
-
Christian Kuhn uploaded patch set 10 07/01/22, 11:02
-
core-ci voted on patch set 10 V +1 07/01/22, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28565
-
Simon Schaufelberger wrote 07/01/22, 12:32
Removed cc Simon Schaufelberger. -
Benni Mack commented on patch set 10 V +1 CR +1 07/04/22, 07:19
Feature-97816-TypoScriptSyntaxImprovements.rst:68ReplyYes. I am in favor of allowing the "// my comment" only on separate lines and deprecating the existing behaviour (in a separate patch) -
Stefan Bürk voted on patch set 10 V +1 CR +1 07/04/22, 07:33
-
Christian Kuhn voted on patch set 10 V +2 CR +2 07/04/22, 11:22
-
Christian Kuhn merged patch set 11 07/04/22, 11:22
-
Benni Mack commented on patch set 11 07/04/22, 11:31
Thanks for the hard work on this! -
Stefan Bürk commented on patch set 11 07/04/22, 19:13
Reply
Same from me. Thanks for the hard work on this, covered with tests. Nice developed.
CurrentObjectPathStack.php:38