Review main Merged

74991[BUGFIX] Fix and improve type annotations of the Repository base class

Oliver Klee CR +2 V +2 Easy +13 −21 updated 07/06/22, 20:50

Commit message

This helps reduce warnings when extensions are type-checked with PHPStan.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Oliver Klee uploaded patch set 1 06/28/22, 16:04

  2. Oliver Klee commented on patch set 1 06/28/22, 16:05

    How to verify: Check that PHPStan is happy.
  3. core-ci voted on patch set 1 V +1 06/28/22, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28462

  4. Benni Mack voted on patch set 1 V +1 CR +1 07/04/22, 07:21

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/06/22, 20:49

  6. Nikita Hovratov merged patch set 2 07/06/22, 20:50