74992[BUGFIX] Use less strict check for empty translated values
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2233
Show 58 earlier messages
-
Elias Häußler uploaded patch set 1 06/29/22, 10:43
-
Oliver Klee commented on patch set 1 06/29/22, 10:50
-
core-ci voted on patch set 1 V +1 06/29/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28478
-
Elias Häußler uploaded patch set 2 06/29/22, 11:27
-
Elias Häußler commented on patch set 2 06/29/22, 11:27
TranslationService.php:701ReplyAck -
core-ci voted on patch set 2 V -1 06/29/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28481
-
core-ci voted on patch set 2 V +1 06/29/22, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28481
-
Oliver Klee voted on patch set 2 CR +1 06/29/22, 11:43
-
Elias Häußler uploaded patch set 3 06/29/22, 12:06
-
Elias Häußler uploaded patch set 4 06/29/22, 12:07
-
Oliver Klee voted on patch set 4 CR +1 06/29/22, 12:09
-
core-ci voted on patch set 4 V +1 06/29/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28485
-
core-ci voted on patch set 3 V +1 06/29/22, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28484
-
Tobias Jungmann voted on patch set 4 CR +1 06/30/22, 12:25
-
waldhacker uploaded patch set 5 06/30/22, 12:30
-
core-ci voted on patch set 5 V -1 06/30/22, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28532
-
waldhacker uploaded patch set 6 06/30/22, 12:44
-
core-ci voted on patch set 6 V +1 06/30/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28533
-
Elias Häußler uploaded patch set 7 06/30/22, 12:57
-
core-ci voted on patch set 7 V -1 06/30/22, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28534
-
core-ci voted on patch set 7 V +1 06/30/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28534
-
Elias Häußler updated the commit message in patch set 8 07/01/22, 09:26
-
core-ci voted on patch set 8 V +1 07/01/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28555
-
Björn Jacob voted on patch set 8 CR +1 07/01/22, 09:36
-
Tobias Jungmann voted on patch set 8 CR +1 07/01/22, 09:40
-
Björn Jacob voted on patch set 8 V +1 07/01/22, 09:59
-
Björn Jacob commented on patch set 8 07/01/22, 10:05
@Elias can we add an information why we are not backporting it to v11. Other people might ask and we can avoid additional communication by mentioning the "problem" of not having it in v11. -
Elias Häußler updated the commit message in patch set 9 07/01/22, 14:37
-
Elias Häußler commented on patch set 9 07/01/22, 14:38
Reply
Done -
core-ci voted on patch set 9 V +1 07/01/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28580
-
Björn Jacob voted on patch set 9 V +1 CR +1 07/01/22, 21:00
-
waldhacker voted on patch set 9 V +2 CR +2 07/02/22, 20:39
-
waldhacker merged patch set 10 07/02/22, 20:42
TranslationService.php:701