74993[BUGFIX] Allow LIVE workspace preview for BE users without LIVE editing permission
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Achim Fritz +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Achim Fritz +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 2936
Show 811 earlier messages
-
Eric Harrer uploaded patch set 1 06/29/22, 15:18
-
Mathias Brodala commented on patch set 1 CR -1 06/29/22, 15:22
This should adhere to the TYPO3 CGL for commit messages: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#summary-line-first-lineOnly priority bugfixes are allowed for TYPO3v10 so this should be removed. -
Eric Harrer updated the commit message in patch set 2 06/29/22, 15:24
-
Eric Harrer updated the commit message in patch set 3 06/29/22, 15:30
-
core-ci voted on patch set 1 V +1 06/29/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28495
-
core-ci voted on patch set 2 V +1 06/29/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28498
-
core-ci voted on patch set 3 V +1 06/29/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28501
-
Nikita Hovratov commented on patch set 3 V +1 CR +1 07/07/22, 21:32
Looks like a legit fix. Couldn't find any possible side-effects. -
Achim Fritz commented on patch set 3 V +1 CR +1 10/24/22, 13:19
works for me
-
Benni Mack commented on patch set 3 CR -2 10/24/22, 13:51
on it -
Benni Mack uploaded patch set 4 10/24/22, 13:54
-
Benni Mack voted on patch set 3 CR 0 10/24/22, 13:54
-
core-ci voted on patch set 4 V +1 10/24/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32689
-
Benni Mack voted on patch set 4 V +1 CR +1 10/24/22, 22:18
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/25/22, 08:05
-
Achim Fritz commented on patch set 4 10/25/22, 08:46
WorkspacePreview.php:119i would prefer, not to change the workspace permissions, but only the context. `$GLOBALS['BE_USER']->setTemporaryWorkspace(0);` can also be removed. -
Oliver Hader voted on patch set 4 CR -1 11/02/22, 12:46
-
Oliver Hader commented on patch set 4 CR 0 11/02/22, 13:02
WorkspacePreview.php:119ReplyBasically `setTemporaryWorkspace(0)` (and it's `checkWorkspace(0)`) are the reasons for having to simulate the `workspace_perms` flag above...WorkspacePreview.php:421Should have been a `PreviewUserAuthentication` earlier, shouldn't it? -
Benni Mack commented on patch set 4 V 0 CR -1 11/02/22, 15:47
on it -
Benni Mack uploaded patch set 5 11/02/22, 16:13
-
core-ci voted on patch set 5 V -1 11/02/22, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32995
-
Benni Mack uploaded patch set 6 11/02/22, 17:08
-
Benni Mack commented on patch set 6 11/02/22, 17:09
WorkspacePreview.php:119Replysince we have a FrontendBackendUserAuthentication (see if clause a few lines above) we extend the check within this class now.WorkspacePreview.php:421ReplyDone -
Benni Mack commented on patch set 6 11/02/22, 17:09
WorkspacePreview.php:119ReplyDone -
core-ci voted on patch set 6 V +1 11/02/22, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32997
-
Benni Mack voted on patch set 6 V +1 CR +1 11/02/22, 17:25
-
Benni Mack voted on patch set 6 V 0 11/02/22, 17:25
-
Benni Mack updated the commit message in patch set 7 11/02/22, 17:26
-
core-ci voted on patch set 7 V +1 11/02/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33000
-
Benni Mack voted on patch set 7 V +1 CR +1 11/02/22, 21:40
-
Christian Kuhn voted on patch set 7 V +1 CR +1 11/03/22, 08:33
-
Achim Fritz voted on patch set 7 V +1 CR +1 11/03/22, 08:35
-
Benni Mack voted on patch set 7 V +2 CR +2 11/03/22, 09:02
-
Benni Mack merged patch set 8 11/03/22, 09:02