Review main Merged

74993[BUGFIX] Allow LIVE workspace preview for BE users without LIVE editing permission

Eric Harrer CR +2 V +2 Easy +21 −5 updated 11/03/22, 09:02

Commit message

Allow temporary setting of the live workspace for backend users that
don't have permission "Edit Live (Online)". These users can now use the
comparison view in the frontend and compare the live version with the
workspace version.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2936

Show 811 earlier messages
  1. Eric Harrer uploaded patch set 1 06/29/22, 15:18

  2. Mathias Brodala commented on patch set 1 CR -1 06/29/22, 15:22

    Only priority bugfixes are allowed for TYPO3v10 so this should be removed.
  3. Eric Harrer updated the commit message in patch set 2 06/29/22, 15:24

  4. Eric Harrer updated the commit message in patch set 3 06/29/22, 15:30

  5. Mathias Brodala commented on patch set 3 06/29/22, 15:31

    Reply

    Done

    Reply

    Done
  6. Eric Harrer commented on patch set 3 06/29/22, 15:31

    Reply

    Done

    Reply

    Done
  7. core-ci voted on patch set 1 V +1 06/29/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28495

  8. core-ci voted on patch set 2 V +1 06/29/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28498

  9. core-ci voted on patch set 3 V +1 06/29/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28501

  10. Nikita Hovratov commented on patch set 3 V +1 CR +1 07/07/22, 21:32

    Looks like a legit fix. Couldn't find any possible side-effects.
  11. Achim Fritz commented on patch set 3 V +1 CR +1 10/24/22, 13:19

    works for me
  1. Benni Mack commented on patch set 3 CR -2 10/24/22, 13:51

    on it
  2. Benni Mack uploaded patch set 4 10/24/22, 13:54

  3. Benni Mack voted on patch set 3 CR 0 10/24/22, 13:54

  4. core-ci voted on patch set 4 V +1 10/24/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32689

  5. Benni Mack voted on patch set 4 V +1 CR +1 10/24/22, 22:18

  6. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/25/22, 08:05

  7. Achim Fritz commented on patch set 4 10/25/22, 08:46

    WorkspacePreview.php:119

    i would prefer, not to change the workspace permissions, but only the context. `$GLOBALS['BE_USER']->setTemporaryWorkspace(0);` can also be removed.
  8. Oliver Hader voted on patch set 4 CR -1 11/02/22, 12:46

  9. Oliver Hader commented on patch set 4 CR 0 11/02/22, 13:02

    WorkspacePreview.php:119 Reply

    Basically `setTemporaryWorkspace(0)` (and it's `checkWorkspace(0)`) are the reasons for having to simulate the `workspace_perms` flag above...

    WorkspacePreview.php:421

    Should have been a `PreviewUserAuthentication` earlier, shouldn't it?
  10. Benni Mack commented on patch set 4 V 0 CR -1 11/02/22, 15:47

    on it
  11. Benni Mack uploaded patch set 5 11/02/22, 16:13

  12. core-ci voted on patch set 5 V -1 11/02/22, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32995

  13. Benni Mack uploaded patch set 6 11/02/22, 17:08

  14. Benni Mack commented on patch set 6 11/02/22, 17:09

    WorkspacePreview.php:119 Reply

    since we have a FrontendBackendUserAuthentication (see if clause a few lines above) we extend the check within this class now.

    WorkspacePreview.php:421 Reply

    Done
  15. Benni Mack commented on patch set 6 11/02/22, 17:09

    WorkspacePreview.php:119 Reply

    Done
  16. core-ci voted on patch set 6 V +1 11/02/22, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32997

  17. Benni Mack voted on patch set 6 V +1 CR +1 11/02/22, 17:25

  18. Benni Mack voted on patch set 6 V 0 11/02/22, 17:25

  19. Benni Mack updated the commit message in patch set 7 11/02/22, 17:26

  20. core-ci voted on patch set 7 V +1 11/02/22, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33000

  21. Benni Mack voted on patch set 7 V +1 CR +1 11/02/22, 21:40

  22. Christian Kuhn voted on patch set 7 V +1 CR +1 11/03/22, 08:33

  23. Achim Fritz voted on patch set 7 V +1 CR +1 11/03/22, 08:35

  24. Benni Mack voted on patch set 7 V +2 CR +2 11/03/22, 09:02

  25. Benni Mack merged patch set 8 11/03/22, 09:02