Review main Merged

74994[DOCS] Improve the validator documentation for editors

Björn Jacob CR +2 V +2 Hard +200 −181 updated 06/30/22, 09:41

Commit message

This patch optimizes the wording of the documentation
and adds links to other documents.

While being on it, images and their corresponding
captions have been fixed throughout the documentation.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Björn Jacob uploaded patch set 1 06/29/22, 15:23

  2. Björn Jacob updated the commit message in patch set 2 06/29/22, 15:26

  3. core-ci voted on patch set 1 V +1 06/29/22, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28497

  4. core-ci voted on patch set 2 V +1 06/29/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28499

  5. Elias Häußler commented on patch set 2 06/29/22, 15:47

    Index.rst:47

    Custom ...

    Index.rst:73

    Custom ...

    Index.rst:98

    Custom ...

    Index.rst:124

    Custom ...

    Index.rst:149

    Custom ...

    Index.rst:175

    Custom ...

    Index.rst:199

    Custom ...

    Index.rst:224

    The ...

    Index.rst:225

    Set ...

    Index.rst:227

    I guess "specify" is correct here. An alternative would be "... to enter a specific domain name".

    Index.rst:258

    Custom ...

    Index.rst:280

    The ...

    Index.rst:282

    Custom ...

    Index.rst:332

    Custom ...
  6. Björn Jacob uploaded patch set 3 06/29/22, 16:10

  7. Björn Jacob commented on patch set 3 06/29/22, 16:12

    Thx. All done.

    Index.rst:47 Reply

    Done

    Index.rst:73 Reply

    Done

    Index.rst:98 Reply

    Done

    Index.rst:124 Reply

    Done

    Index.rst:149 Reply

    Done

    Index.rst:175 Reply

    Done

    Index.rst:199 Reply

    Done

    Index.rst:224 Reply

    Done

    Index.rst:225 Reply

    Done

    Index.rst:227 Reply

    Done

    Index.rst:258 Reply

    Done

    Index.rst:280 Reply

    Done

    Index.rst:282 Reply

    Done

    Index.rst:332 Reply

    Done
  8. core-ci voted on patch set 3 V +1 06/29/22, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28506

  9. Sybille Peters commented on patch set 3 06/29/22, 20:59

    Index.rst:28

    If this should be a caption, you can indent here, see https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/WritingReST/Images.html#example-2-image-with-caption (same with the other images)
  10. Elias Häußler commented on patch set 3 06/30/22, 06:06

    Index.rst:227 Reply

    This is still not resolved in PS 3.
  11. Björn Jacob uploaded patch set 4 06/30/22, 07:37

  12. Björn Jacob commented on patch set 4 06/30/22, 07:40

    Thanks for your reviews. Fixed all captions. And @elias you are right, didn't understand the problem. Now I do :)

    Index.rst:28 Reply

    Done

    Index.rst:227 Reply

    Done
  13. core-ci voted on patch set 4 V +1 06/30/22, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28519

  14. Elias Häußler voted on patch set 4 V +1 CR +1 06/30/22, 07:51

  15. waldhacker voted on patch set 4 V +2 CR +2 06/30/22, 09:40

  16. waldhacker merged patch set 5 06/30/22, 09:41