Review main Merged

74995[TASK] Clarify docblock for addPlugin

Sybille Peters CR +2 V +2 Easy +1 −1 updated 06/30/22, 04:08

Commit message

Clarify in the docblock that it is also possible to pass an icon
identifier to addPlugin, not just an icon path.

The first argument of the method ExtensionManagementUtility::addPlugin()
expects an array. The possible values are explained in the docblock. For
the third value, the icon, it is possible to pass a path or an icon
identifier.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Sybille Peters uploaded patch set 1 06/29/22, 15:30

  2. core-ci voted on patch set 1 V -1 06/29/22, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28500

  3. Sybille Peters rebased onto patch set 2 06/29/22, 16:15

  4. core-ci voted on patch set 2 V +1 06/29/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28508

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 06/29/22, 17:46

  6. Oliver Klee voted on patch set 2 V +1 CR +1 06/29/22, 21:44

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 06/30/22, 04:07

  8. Stefan Bürk merged patch set 3 06/30/22, 04:08