Review main Merged

74998[BUGFIX] Do not log failed HMAC validations in ext:frontend

Torben Hansen CR +2 V +2 Easy +12 −5 updated 07/01/22, 19:50

Commit message

With #93667 logging of HMAC validation errors caused by potentially
manipulated form submissions has been disabled. The change does
however not consider exceptions handled in the
ProductionExceptionHandler for content objects in ext:frontend.

This change prevents logging of two exceptions caused by potential
manipulated form submissions in ProductionExceptionHandler for
content objects.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Markus Klein +1
    • Oliver Hader +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Torben Hansen uploaded patch set 1 06/29/22, 17:10

  2. core-ci voted on patch set 1 V -1 06/29/22, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28510

  3. Torben Hansen updated the commit message in patch set 2 06/29/22, 17:27

  4. core-ci voted on patch set 2 V +1 06/29/22, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28511

  5. Oliver Klee voted on patch set 2 CR +1 06/29/22, 18:43

  6. Oliver Hader voted on patch set 2 CR +1 06/29/22, 19:18

  7. Markus Klein voted on patch set 2 V +1 CR +1 06/29/22, 20:39

  8. Rudy Gnodde voted on patch set 2 CR +1 06/30/22, 06:40

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 07/01/22, 19:50

  10. Christian Kuhn merged patch set 3 07/01/22, 19:50