74999[BUGFIX] Do not use "[Empty]" label for finisher options in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 4
Files 1
Review log 910
-
Elias Häußler uploaded patch set 1 06/30/22, 08:16
-
core-ci voted on patch set 1 V +1 06/30/22, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28520
-
Mathias Brodala commented on patch set 1 06/30/22, 08:25
-
Elias Häußler commented on patch set 1 06/30/22, 08:34
FinisherOptionGenerator.php:94ReplyHmm, my idea was to streamline this with main and 11.5, where it's done exactly this way. However, I agree that re-using the variable for other things is not a good idea. I'm not sure which is the better solution. -
Mathias Brodala commented on patch set 1 06/30/22, 08:38
FinisherOptionGenerator.php:94ReplyYou are right, your change re-aligns with the latest main/v11. This is certainly valuable to reduce overhead for backports. Fine with me in this case. -
Oliver Hader commented on patch set 1 V +1 CR +1 06/30/22, 11:02
Awesome! I did not spot the order got mixed here (v10 vs v11)... -
Oliver Klee voted on patch set 1 CR +1 06/30/22, 11:41
-
Oliver Hader commented on patch set 1 06/30/22, 13:02
Considered a regression of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72901 -
Oliver Hader voted on patch set 1 V +2 CR +2 06/30/22, 13:02
-
Oliver Hader merged patch set 2 06/30/22, 13:02
FinisherOptionGenerator.php:94