Review 10.4 Merged

74999[BUGFIX] Do not use "[Empty]" label for finisher options in FormEngine

Elias Häußler CR +2 V +2 Easy +4 −4 updated 06/30/22, 13:02

Commit message

With #96478, the default value for overridden finisher options in
FormEngine was set to the translated label "[Empty]" in case the
finisher option was empty. Since applying labels to values does not
really make sense here, the original option value is now set as default
value in FormEngine, ignoring the generated label.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 4

Files 1

Review log 910

  1. Elias Häußler uploaded patch set 1 06/30/22, 08:16

  2. core-ci voted on patch set 1 V +1 06/30/22, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28520

  3. Mathias Brodala commented on patch set 1 06/30/22, 08:25

    FinisherOptionGenerator.php:94

    I'd rather leave this in place here and rename the following $optionValue e.g. to $labelValue to avoid overwriting the value. Generally it doesn't make sense to overwrite the value here.
  4. Elias Häußler commented on patch set 1 06/30/22, 08:34

    FinisherOptionGenerator.php:94 Reply

    Hmm, my idea was to streamline this with main and 11.5, where it's done exactly this way. However, I agree that re-using the variable for other things is not a good idea. I'm not sure which is the better solution.
  5. Mathias Brodala commented on patch set 1 06/30/22, 08:38

    FinisherOptionGenerator.php:94 Reply

    You are right, your change re-aligns with the latest main/v11. This is certainly valuable to reduce overhead for backports. Fine with me in this case.
  6. Oliver Hader commented on patch set 1 V +1 CR +1 06/30/22, 11:02

    Awesome! I did not spot the order got mixed here (v10 vs v11)...
  7. Oliver Klee voted on patch set 1 CR +1 06/30/22, 11:41

  8. Oliver Hader commented on patch set 1 06/30/22, 13:02

  9. Oliver Hader voted on patch set 1 V +2 CR +2 06/30/22, 13:02

  10. Oliver Hader merged patch set 2 06/30/22, 13:02