Review main Abandoned

75000[BUGFIX] Skip HMAC validation for multi-value properties in form editor

Elias Häußler CR 0 V 0 Easy +1 −1 updated 10/19/22, 06:44

Commit message

With #85044, HMAC validation for form definitions in the backend form
editor was introduced. Since then, a transformed form definition
contains HMAC values for all form elements and their properties, except
for multi-value properties. Those properties were not secured by an
appropriate HMAC value. However, the HMAC validation was still in place,
even for multi-value properties. This led to an exception when trying to
save a form that contains multi-value properties.

Since multi-value properties don't have an appropriate HMAC value, the
HMAC validation is now skipped for those properties.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 1

Review log 56

  1. Elias Häußler uploaded patch set 1 06/30/22, 09:39

  2. core-ci voted on patch set 1 V +1 06/30/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28523

  3. Oliver Hader commented on patch set 1 CR -1 07/01/22, 09:57

    FormDefinitionValidationService.php:338 Unresolved

    `_label` and `_value` seem to be specific in the `EmailToReceiver` finisher... I think instead of skipping these properties (which might be used differently in other finishers), corresponding HMAC values should be generated as well.
  4. Oliver Hader commented on patch set 1 07/01/22, 10:47

    Alternative approach, without skipping, but creating HMACs for those items instead: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75009
  5. waldhacker commented on patch set 1 CR -1 07/02/22, 14:05

    -1 for review
  6. Elias Häußler abandoned the change 10/19/22, 06:44