75004[BUGFIX] Assure object is used to render hidden identity fields
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- waldhacker +1
- Björn Jacob +1
-
Verified V +2 Done
- Oliver Hader +2
- waldhacker +1
- Björn Jacob +1
- core-ci +1 CI
Issues 2
Files 1
Review log 68
-
Elias Häußler uploaded patch set 1 07/01/22, 08:36
-
core-ci voted on patch set 1 V -1 07/01/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28551
-
core-ci voted on patch set 1 V +1 07/01/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28551
-
Oliver Hader commented on patch set 1 V +1 CR +1 07/01/22, 08:52
Previously `renderHiddenIdentityField` returned an empty string in case not object was given - which is not added as explicit check. Looks good to me 👍 -
Björn Jacob commented on patch set 1 V +1 CR +1 07/01/22, 08:58
Awesome! -
waldhacker voted on patch set 1 V +1 CR +1 07/01/22, 08:58
-
Oliver Hader voted on patch set 1 V +2 CR +2 07/01/22, 08:59
-
Oliver Hader merged patch set 2 07/01/22, 08:59