75005[BUGFIX] Avoid yoda-style conditions in PHP
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Björn Jacob +1
- Oliver Hader +1
- Mathias Brodala +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Hader +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 19
- Build/php-cs-fixer.php3+1 −0
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+1 −1
- typo3/sysext/core/Classes/Command/Descriptor/TextDescriptor.php+1 −1
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+7 −7
- typo3/sysext/core/Classes/Http/JsonResponse.php+1 −1
- typo3/sysext/core/Classes/Http/UploadedFile.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+1 −1
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+1 −1
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php+2 −2
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariant.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Utility/CompressionUtility.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −2
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/AdminRecycleTest.php+4 −4
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/UserRecycleTest.php+4 −4
Review log 1416
-
Elias Häußler uploaded patch set 1 07/01/22, 08:50
-
Mathias Brodala commented on patch set 1 07/01/22, 08:55
-
Björn Jacob voted on patch set 1 CR +1 07/01/22, 08:55
-
Elias Häußler commented on patch set 1 07/01/22, 08:57
php-cs-fixer.php:102ReplySetting it to `false` had no effect when I initially tested it. Have you successfully tried it? -
core-ci voted on patch set 1 V +1 07/01/22, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28552
-
Mathias Brodala commented on patch set 1 V +1 CR +1 07/01/22, 09:02
php-cs-fixer.php:102ReplyHm, just had a look at the source any you are right, one must configure each type separately. Not sure why I assumed that just "false" works, thanks for the hint. -
Nikita Hovratov commented on patch set 1 07/01/22, 09:09
Let's exclude 10.4 from this patch, as it is only cosmetical. -
Elias Häußler updated the commit message in patch set 2 07/01/22, 09:11
-
Björn Jacob voted on patch set 2 CR +1 07/01/22, 09:12
-
Mathias Brodala voted on patch set 2 V +1 CR +1 07/01/22, 09:14
-
core-ci voted on patch set 2 V +1 07/01/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28554
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 07/01/22, 09:27
-
Oliver Hader voted on patch set 2 CR +1 07/01/22, 09:29
-
Oliver Hader voted on patch set 2 V +1 07/01/22, 09:30
-
Nikita Hovratov voted on patch set 2 V +2 CR +2 07/01/22, 09:31
-
Nikita Hovratov merged patch set 3 07/01/22, 09:37
php-cs-fixer.php:102