Review 11.5 Merged

75008[BUGFIX] Avoid yoda-style conditions in PHP

Nikita Hovratov CR +2 V +2 Normal +38 −37 updated 07/01/22, 10:28

Commit message

The core team agreed on not using yoda-style conditions in PHP. An
appropriate PHP-CS-Fixer rule to explicitly disable yoda-style has
been added to ensure that this coding style is respected. Additionally,
all yoda-style conditions have been transformed to normal conditions.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 22

Review log 46

  1. Nikita Hovratov uploaded patch set 1 07/01/22, 09:45

  2. core-ci voted on patch set 1 V +1 07/01/22, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28560

  3. Nikita Hovratov uploaded patch set 2 07/01/22, 10:01

  4. core-ci voted on patch set 2 V +1 07/01/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28562

  5. Nikita Hovratov voted on patch set 2 V +2 CR +2 07/01/22, 10:27

  6. Nikita Hovratov merged patch set 3 07/01/22, 10:28