Review main Merged

75009[BUGFIX] Cover multi-value properties in form editor with HMAC

Oliver Hader CR +2 V +2 Easy +17 −1 updated 10/19/22, 07:06

Commit message

With #85044, HMAC validation for form definitions in the backend form
editor was introduced. However, nested multi-valued options have not
been signed with corresponding HMAC values - which lead to error
messages when persisting the form again in the backend.

The exception for `_value` and `_label` (properties used for those
multi-valued items) have been removed when generating HMAC values.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Elias Häußler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Elias Häußler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1317

  1. Oliver Hader uploaded patch set 1 07/01/22, 10:44

  2. core-ci voted on patch set 1 V -1 07/01/22, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28564

  3. Oliver Hader uploaded patch set 2 07/01/22, 12:49

  4. waldhacker commented on patch set 2 07/01/22, 12:56

    On it
  5. core-ci voted on patch set 2 V +1 07/01/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28568

  6. Oliver Hader commented on patch set 2 07/01/22, 13:49

  7. Oliver Hader rebased onto patch set 3 07/11/22, 10:36

  8. core-ci voted on patch set 3 V +1 07/11/22, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28878

  9. Oliver Hader rebased onto patch set 4 10/03/22, 15:15

  10. Oliver Hader marked it ready for review 10/03/22, 15:15

  11. core-ci voted on patch set 4 V +1 10/03/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31947

  12. Benni Mack voted on patch set 4 V +1 CR +1 10/12/22, 09:32

  13. Stefan Bürk voted on patch set 4 CR +1 10/12/22, 11:21

  14. Stefan Bürk voted on patch set 4 V +1 10/13/22, 05:29

  15. Elias Häußler voted on patch set 4 V +1 CR +1 10/19/22, 06:47

  16. Oliver Hader voted on patch set 4 V +2 CR +2 10/19/22, 07:06

  17. Oliver Hader merged patch set 5 10/19/22, 07:06