Review main Merged

75017[TASK] Improve return type for GeneralUtility:getUrl

Georg Ringer CR +2 V +2 Easy +1 −1 updated 07/01/22, 19:04

Commit message

Set the return type to string|false instead of mixed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1418

  1. Georg Ringer uploaded patch set 1 07/01/22, 17:45

  2. Georg Ringer commented on patch set 1 07/01/22, 17:46

    This change is ready for review.
  3. Oliver Klee updated the commit message in patch set 2 07/01/22, 17:47

  4. Oliver Klee commented on patch set 2 07/01/22, 17:48

    GeneralUtility.php:1539

    We probably can even narrow this down to string|false, I think (also in the commit message).
  5. core-ci voted on patch set 2 V +1 07/01/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28596

  6. core-ci voted on patch set 1 V +1 07/01/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28595

  7. Christian Kuhn uploaded patch set 3 07/01/22, 18:31

  8. Christian Kuhn updated the commit message in patch set 4 07/01/22, 18:31

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 07/01/22, 18:32

  10. Simon Schaufelberger commented on patch set 4 07/01/22, 18:36

    Wouldn't it make sense to also have a look at other places where mixed is returned llike _GP for example and so everything together?
  11. core-ci voted on patch set 3 V +1 07/01/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28597

  12. core-ci voted on patch set 4 V +1 07/01/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28598

  13. Oliver Klee voted on patch set 4 V +1 CR +1 07/01/22, 18:57

  14. Oliver Klee commented on patch set 4 07/01/22, 18:58

    I‘d prefer to change the other places in a separate change so we can get this change merged as soon as possible.
  15. Christian Kuhn commented on patch set 4 V +2 CR +2 07/01/22, 19:02

    Reply

    i actually hope we can deprecate _GP soonish in favor of fixing it ;)
  16. Christian Kuhn commented on patch set 4 07/01/22, 19:03

    GeneralUtility.php:1539 Reply

    Done
  17. Christian Kuhn merged patch set 5 07/01/22, 19:03

  18. Simon Schaufelberger commented on patch set 5 07/01/22, 19:04

    Reply

    Well, this was just one example out of many. There are several other places where mixed is used.