75017[TASK] Improve return type for GeneralUtility:getUrl
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Georg Ringer uploaded patch set 1 07/01/22, 17:45
-
Georg Ringer commented on patch set 1 07/01/22, 17:46
This change is ready for review. -
Oliver Klee updated the commit message in patch set 2 07/01/22, 17:47
-
Oliver Klee commented on patch set 2 07/01/22, 17:48
GeneralUtility.php:1539We probably can even narrow this down to string|false, I think (also in the commit message). -
core-ci voted on patch set 2 V +1 07/01/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28596
-
core-ci voted on patch set 1 V +1 07/01/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28595
-
Christian Kuhn uploaded patch set 3 07/01/22, 18:31
-
Christian Kuhn updated the commit message in patch set 4 07/01/22, 18:31
-
Christian Kuhn voted on patch set 4 V +1 CR +1 07/01/22, 18:32
-
Simon Schaufelberger commented on patch set 4 07/01/22, 18:36
Wouldn't it make sense to also have a look at other places where mixed is returned llike _GP for example and so everything together? -
core-ci voted on patch set 3 V +1 07/01/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28597
-
core-ci voted on patch set 4 V +1 07/01/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28598
-
Oliver Klee voted on patch set 4 V +1 CR +1 07/01/22, 18:57
-
Oliver Klee commented on patch set 4 07/01/22, 18:58
I‘d prefer to change the other places in a separate change so we can get this change merged as soon as possible. -
Christian Kuhn commented on patch set 4 V +2 CR +2 07/01/22, 19:02
Reply
i actually hope we can deprecate _GP soonish in favor of fixing it ;) -
Christian Kuhn commented on patch set 4 07/01/22, 19:03
GeneralUtility.php:1539ReplyDone -
Christian Kuhn merged patch set 5 07/01/22, 19:03
-
Simon Schaufelberger commented on patch set 5 07/01/22, 19:04
Reply
Well, this was just one example out of many. There are several other places where mixed is used.